chore(md): updated readme and contributing guidelines #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/website |
richardlau
reviewed
Mar 10, 2023
richardlau
reviewed
Mar 10, 2023
EmirBoyaci
reviewed
Mar 10, 2023
mikeesto
reviewed
Mar 11, 2023
mikeesto
reviewed
Mar 11, 2023
|
Going to update this doc asap. Just relaxing today after a long trip. Thank you all for the feedback so far :) BTW, @mikeesto an off-topic thingy, but I sent you a DM on Twitter :) |
ovflowd
requested review from
richardlau,
mikeesto and
EmirBoyaci
and removed request for
mikeesto and
EmirBoyaci
EmirBoyaci
reviewed
Mar 12, 2023
|
cc @richardlau requesting re-review whenever you get some time 🙇 |
mikeesto
approved these changes
Mar 14, 2023
|
LGTM 😀 |
aymen94
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to the README and the CONTRIBUTION guidelines.
This PR needs a review and approval from @nodejs/website as it changes the Approval Requirements, Commit Guidelines and PR guidelines.