-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): fix typo in translation keys #5092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution 😄
Always! But, do you have any idea why PR checks didn't start? I am asking this because I think you're maintainer, so it should be started.. Isn't it? |
Yeah, sounds like a weird bug. GitHub is not giving me any option to start them 😅 I wonder why. Let me see if I can force trigger them. |
Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits. |
Sure but signed commit requirement is not included in Contributing Guide. IMHO you should also include it.. |
Correct, let me update that. |
@ovflowd could you please check it again? I force pushed signed commit :) |
Two i18n keys that includes typo changed Fixes nodejs#5091
I was looking for why it is stuck on "Expected — Waiting for status to be reported" stage and found one solution. Unfortunately, the solution did not work. Second force-push was for this trial. |
Ok next solution did not work also. I will not do anything after now XD |
Now it worked! |
Yea, we got 🟢 also! 🚀 |
Two i18n keys that includes typo changed
Fixes #5091