Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): fix typo in translation keys #5092

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Conversation

EmirBoyaci
Copy link
Contributor

Two i18n keys that includes typo changed

Fixes #5091

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution 😄

@EmirBoyaci
Copy link
Contributor Author

LGTM! Thank you for your contribution 😄

Always! But, do you have any idea why PR checks didn't start? I am asking this because I think you're maintainer, so it should be started.. Isn't it?

@ovflowd
Copy link
Member

ovflowd commented Mar 10, 2023

Always! But, do you have any idea why PR checks didn't start? I am asking this because I think you're maintainer, so it should be started.. Isn't it?

Yeah, sounds like a weird bug. GitHub is not giving me any option to start them 😅

I wonder why. Let me see if I can force trigger them.

@ovflowd
Copy link
Member

ovflowd commented Mar 10, 2023

Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits.

@EmirBoyaci
Copy link
Contributor Author

Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits.

Sure but signed commit requirement is not included in Contributing Guide. IMHO you should also include it..

@ovflowd
Copy link
Member

ovflowd commented Mar 10, 2023

Correct, let me update that.

@EmirBoyaci
Copy link
Contributor Author

@ovflowd could you please check it again? I force pushed signed commit :)

Two i18n keys that includes typo changed

Fixes nodejs#5091
@EmirBoyaci
Copy link
Contributor Author

I was looking for why it is stuck on "Expected — Waiting for status to be reported" stage and found one solution. Unfortunately, the solution did not work. Second force-push was for this trial.

@EmirBoyaci EmirBoyaci closed this Mar 10, 2023
@EmirBoyaci EmirBoyaci reopened this Mar 10, 2023
@EmirBoyaci
Copy link
Contributor Author

Ok next solution did not work also. I will not do anything after now XD

@ovflowd
Copy link
Member

ovflowd commented Mar 10, 2023

Ok next solution did not work also. I will not do anything after now XD

Now it worked!

@EmirBoyaci
Copy link
Contributor Author

Ok next solution did not work also. I will not do anything after now XD

Now it worked!

Yea, we got 🟢 also! 🚀

@ovflowd ovflowd merged commit 531ce41 into nodejs:main Mar 12, 2023
@EmirBoyaci EmirBoyaci deleted the fix-5091 branch March 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: Translation Keys
3 participants