Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(Style): introduce branding from nodejs Website Redesign #5079

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Chore(Style): introduce branding from nodejs Website Redesign #5079

merged 6 commits into from
Mar 13, 2023

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Mar 8, 2023

Proposal

This is the beginning of the style/layout migration.

For that I created this little piece of code to support both styles at the same time.

The idea is just to go ahead. For the user it doesn't bring anything it's only for our contributor.

We could have put it in a PR with modifications of style and layout. But it seemed cleaner to do it in two shots.

The difference in syntax between the two variables allows them to co-exist.

Checklist

  • Test if the "old" design work good.
  • Test if the new var work good.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is the first step for the styles of nodejs.dev. Nicely done!

@AugustinMauroy
Copy link
Member Author

This is the first step for the styles of nodejs.dev. Nicely done!

I'm so Hype !!!!

@ovflowd ovflowd enabled auto-merge March 13, 2023 18:41
@ovflowd ovflowd added this pull request to the merge queue Mar 13, 2023
@ovflowd ovflowd removed this pull request from the merge queue due to the queue being cleared Mar 13, 2023
@ovflowd ovflowd added this pull request to the merge queue Mar 13, 2023
Merged via the queue into nodejs:main with commit 24f6828 Mar 13, 2023
@AugustinMauroy AugustinMauroy deleted the chore(styles)-starting-the-migration branch March 13, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants