Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): added and updated workflows #5078

Merged
merged 2 commits into from
Mar 9, 2023
Merged

chore(workflows): added and updated workflows #5078

merged 2 commits into from
Mar 9, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 8, 2023

This PR removes the old CodeQL workflow (as now GitHub provides CodeQL built-in within the repository settings), introduces a GitHub Pages workflow, so we can finally introduce deployments on the existing Pull Request workflow.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a rubber-stamp but certainly using the default CodeQL is 👍 and the other stuff looks good based on a quick review.

@ovflowd ovflowd merged commit fb00893 into nodejs:main Mar 9, 2023
@ovflowd ovflowd deleted the chore/workflows-gh-pages-codeql branch March 9, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants