Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): remove deprecated usage of npm ci --only #5024

Merged
merged 1 commit into from
Mar 25, 2023
Merged

fix(docs): remove deprecated usage of npm ci --only #5024

merged 1 commit into from
Mar 25, 2023

Conversation

erfanium
Copy link
Contributor

@erfanium erfanium commented Jan 17, 2023 •
edited
Loading

this is the npm output when you using npm ci --only=production

npm version: 8.19.0

Step 4/7 : RUN npm ci --only=production
 ---> Running in bfc1319afc62
npm WARN config only Use `--omit=dev` to omit dev dependencies from the install.

ovflowd
ovflowd approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM!

AugustinMauroy
AugustinMauroy approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution (thanks for looking at the different languages)

@Trott
Copy link
Member

Trott commented Jan 18, 2023

@nodejs/docker

@ovflowd ovflowd enabled auto-merge (squash) February 27, 2023 14:59
auto-merge was automatically disabled March 9, 2023 11:01

Merge queue setting changed

@ovflowd
Copy link
Member

ovflowd commented Mar 14, 2023 •
edited
Loading

Hey @erfanium could you rebase this PR? (I'm going to merge after rebase as the @nodejs/docker WG hasn't said anything)

@erfanium
Copy link
Contributor Author

@ovflowd sorry for my late reply. i'll do it today

@SEWeiTung
Copy link
Contributor

@erfanium：Thanks for your 1st contribution to Nodejs.org and if you are free, please solve the conflict problems so as to make your changes get merged :)

@erfanium erfanium requested a review from a team as a code owner March 23, 2023 21:04
@erfanium
Copy link
Contributor Author

@MaledongGit @ovflowd
Sorry all, we are in new year holidays in Iran. I have fixed all conflicts

@manishprivet manishprivet merged commit e8e4acd into nodejs:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@manishprivet manishprivet manishprivet approved these changes

@mikeesto mikeesto mikeesto approved these changes

@aymen94 aymen94 aymen94 approved these changes

@ovflowd ovflowd ovflowd approved these changes

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@erfanium @Trott @ovflowd @SEWeiTung @PeterDaveHello @aymen94 @mikeesto @manishprivet @AugustinMauroy