CI: restrict pushes event and add workflow_dispatch
#4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to trigger the workflow manually
Trott
approved these changes
Dec 19, 2021
|
Is there a specific reason we'd need to manually trigger that you had in mind? Not opposed at all (I advocated for this feature to be shipped 😅) , just want to make sure adding it actually solves a (potential) problem. |
|
The main idea is to restrict triggering the actions on all pushes (we should change it only to main since we always use PRs) and so this feature makes it possible to test a branch before opening a PR or without having a PR. Right now, we have duplicate runs for pushes and PRs. |
XhmikosR
changed the title
workflow_dispatchworkflow_dispatch
|
I updated the PR with the proposed changes, please have another look. :) |
XhmikosR
changed the title
workflow_dispatchworkflow_dispatch
Trott
approved these changes
Dec 19, 2021
aymen94
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to trigger the workflow manually
Might be worth restricting on push now that we can manually trigger the workflow. I'll leave that for someone else to tackle later.