Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display LTS and Stable API links on docs page #324

Merged
merged 1 commit into from
Dec 8, 2015
Merged

Conversation

phillipj
Copy link
Member

@phillipj phillipj commented Nov 4, 2015

Part of the multiple version docs discussion in #305.

skjermbilde 2015-11-04 kl 08 54 44

Using the same URLs as we've got on the frontpage, e.g:

Are those URLs appropriate or would we want to use any of these aliases?

  • latest -> v5.0.0
  • latest-argon -> v4.2.2
  • latest-v0.10.x -> v0.10.40
  • latest-v0.12.x -> v0.12.7
  • latest-v4.x -> v4.2.2
  • latest-v5.x -> v5.0.0

@dominykas
Copy link
Member

May I suggest adding "LTS" to every LTS version label? i.e. display:

  • v4.2.2 LTS API
  • v5.0.0 API

@rvagg
Copy link
Member

rvagg commented Nov 4, 2015

perhaps use https://nodejs.org/docs/latest-v4.x/api/ for the link instead, you could also do the same with the v5.x link .. maybe. Also note that https://nodejs.org/docs/latest-argon/api/ is a thing if you want to reinforce the LTS name which is not a bad idea.

@phillipj
Copy link
Member Author

May I suggest adding "LTS" to every LTS version label?

If so, why shouldn't we add "Stable" to v5 also?

@thefourtheye
Copy link
Contributor

If so, why shouldn't we add "Stable" to v5 also?

Yes, that would be better.

@dominykas
Copy link
Member

If so, why shouldn't we add "Stable" to v5 also?

Yes, that would be better.

No it would not.

The idea is to highlight the LTS release - if each release is labeled, then the information density increases and it becomes hard to see the trees in the forest. If the general recommendation is "when unsure - choose LTS", then LTS should be highlighted. Or, you can think about it this way - both LTS and Stable are "stable", but "LTS" is "special Stable", therefore it deserves an honorable mention.

If "unstable" / "alpha" / "beta" releases existed - they should also be marked as such (although better yet, they should only be displayed to power users, i.e. they should be absent from the lists on primary pages).

I am falling back on the laws of simplicity here - Simplicity is about subtracting the obvious, and adding the meaningful. - but similar concepts can be found in plenty of other generic usability advice.

@phillipj phillipj force-pushed the multiple-api-docs branch 2 times, most recently from 3a2914a to aa14473 Compare November 11, 2015 20:30
@@ -51,12 +51,8 @@
&#47; <a href="https://github.com/nodejs/node/blob/{{ project.currentVersions.stable }}/CHANGELOG.md">{{ labels.stable }}</a>
</li>
<li>
{{#if project.currentVersions.stable}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement was put into place before we had Stable and LTS on the website - as that's old news, it could be removed.

@phillipj
Copy link
Member Author

Just pushed a couple of updates:

  • Use https://nodejs.org/docs/latest-v4.x/api/ and latest-v5.x URLs
  • To reduce duplication and ensure consistency, I extracted docs URL generation into a Handlebars helper, which is also used on the frontpage
  • Added "LTS" behind v4.x label

TBH I dont have a strong opinion about putting LTS into the v4.x link or not, but I agree with @dominykas reasoning.

skjermbilde 2015-11-11 kl 21 51 59

@phillipj
Copy link
Member Author

An updated screenshot now that we've got the Guides link aswell.

Any thoughts on this anyone? It's ready to go as soon as it gets a collaborator thumbs up.

skjermbilde 2015-11-18 kl 22 38 31

@rnsloan
Copy link
Contributor

rnsloan commented Nov 21, 2015

👍

@bnb
Copy link
Contributor

bnb commented Nov 21, 2015

-1 on the last proposed solution.

LTS and Stable should both be marked - giving context to one and withholding context from other is a very bad idea.

Additionally, from a design view, there is Way too much going on in the green links, making them extremely hard for humans to parse. Having a v, number, full stop, number, full stop, number, full stop, text element one, text element two is far too much. We need to simplify this.

So here are my suggestions:

  • Remove v - giving the number implies version
  • Remove LTS from 4.2.2
  • Append LTS and Stable in smaller gray lettering or a gray tag

@rnsloan
Copy link
Contributor

rnsloan commented Nov 21, 2015

When you have an LTS version of software, personally, I have never found the need to state everywhere that the later release is stable. Ubuntu do not do it: http://www.ubuntu.com/server , https://help.ubuntu.com/

@dominykas
Copy link
Member

@bnb you're assuming the reader knows the difference between "LTS" and "Stable" - the label needs to highlight it - both are "Stable", but only one is "LTS".

@bnb
Copy link
Contributor

bnb commented Nov 22, 2015

@rnsloan @dominykas Fair play. However, I still maintain that those changes (minus adding Stable) should be made.

@phillipj
Copy link
Member Author

phillipj commented Dec 7, 2015

Something like this @bnb?

screen shot 2015-12-07 at 07 50 13

@stevemao
Copy link
Contributor

stevemao commented Dec 7, 2015

Looks good :)

Linking to https://nodejs.org/dist/latest-v4.x/docs/api/
and latest-v5 respectively. This also affects the frontpage
as it re-uses the same logic (handlebars helper) to generate
API doc URLs.
phillipj added a commit that referenced this pull request Dec 8, 2015
Display LTS and Stable API links on docs page
@phillipj phillipj merged commit ec97dfc into master Dec 8, 2015
@phillipj phillipj deleted the multiple-api-docs branch December 8, 2015 20:25
@phillipj
Copy link
Member Author

phillipj commented Dec 8, 2015

Thanks for the feedback everyone! 👍

@bnb I like your thoughts about removing the v from v4.2.3 and v5.1.1! I thought it better fits a new PR/issue, as it should probably be done throughout the site, not only the docs page - up for grabs anyone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants