-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display LTS and Stable API links on docs page #324
Conversation
May I suggest adding "LTS" to every LTS version label? i.e. display:
|
perhaps use https://nodejs.org/docs/latest-v4.x/api/ for the link instead, you could also do the same with the v5.x link .. maybe. Also note that https://nodejs.org/docs/latest-argon/api/ is a thing if you want to reinforce the LTS name which is not a bad idea. |
If so, why shouldn't we add "Stable" to v5 also? |
Yes, that would be better. |
No it would not. The idea is to highlight the LTS release - if each release is labeled, then the information density increases and it becomes hard to see the trees in the forest. If the general recommendation is "when unsure - choose LTS", then LTS should be highlighted. Or, you can think about it this way - both LTS and Stable are "stable", but "LTS" is "special Stable", therefore it deserves an honorable mention. If "unstable" / "alpha" / "beta" releases existed - they should also be marked as such (although better yet, they should only be displayed to power users, i.e. they should be absent from the lists on primary pages). I am falling back on the laws of simplicity here - Simplicity is about subtracting the obvious, and adding the meaningful. - but similar concepts can be found in plenty of other generic usability advice. |
3a2914a
to
aa14473
Compare
@@ -51,12 +51,8 @@ | |||
/ <a href="https://github.com/nodejs/node/blob/{{ project.currentVersions.stable }}/CHANGELOG.md">{{ labels.stable }}</a> | |||
</li> | |||
<li> | |||
{{#if project.currentVersions.stable}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if statement was put into place before we had Stable and LTS on the website - as that's old news, it could be removed.
aa14473
to
063806f
Compare
Just pushed a couple of updates:
TBH I dont have a strong opinion about putting LTS into the v4.x link or not, but I agree with @dominykas reasoning. |
063806f
to
de48a52
Compare
👍 |
-1 on the last proposed solution. LTS and Stable should both be marked - giving context to one and withholding context from other is a very bad idea. Additionally, from a design view, there is Way too much going on in the green links, making them extremely hard for humans to parse. Having a So here are my suggestions:
|
When you have an LTS version of software, personally, I have never found the need to state everywhere that the later release is stable. Ubuntu do not do it: http://www.ubuntu.com/server , https://help.ubuntu.com/ |
@bnb you're assuming the reader knows the difference between "LTS" and "Stable" - the label needs to highlight it - both are "Stable", but only one is "LTS". |
@rnsloan @dominykas Fair play. However, I still maintain that those changes (minus adding |
de48a52
to
bca773b
Compare
bca773b
to
9bdf690
Compare
Something like this @bnb? |
Looks good :) |
Linking to https://nodejs.org/dist/latest-v4.x/docs/api/ and latest-v5 respectively. This also affects the frontpage as it re-uses the same logic (handlebars helper) to generate API doc URLs.
9bdf690
to
3855521
Compare
Display LTS and Stable API links on docs page
Thanks for the feedback everyone! 👍 @bnb I like your thoughts about removing the |
Part of the multiple version docs discussion in #305.
Using the same URLs as we've got on the frontpage, e.g:
Are those URLs appropriate or would we want to use any of these aliases?