Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guides item to Docs nav #313

Closed
wants to merge 2 commits into from
Closed

Add Guides item to Docs nav #313

wants to merge 2 commits into from

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 31, 2015

Added the Guides item to both locations: site.json and layouts/docs.hbs, as per #254.

&! (bitandbang) added 2 commits October 31, 2015 13:44
Added the Guides item to the Docs nav.
Added the guides link to the navigation in the docs handlebars layout
@matthewloring
Copy link
Contributor

@bnb Thanks for doing this!

@bnb
Copy link
Contributor Author

bnb commented Nov 1, 2015

@matthewloring No problem! It would be helpful for a couple people to check and make sure the syntax for the changes is correct.

@matthewloring
Copy link
Contributor

cc @Qard @fhemberger

@Qard
Copy link
Member

Qard commented Nov 2, 2015

Is there an index page for the guides section somewhere?

@bnb
Copy link
Contributor Author

bnb commented Nov 2, 2015

@Quard I meant to ask that. I don't think so.

@bnb
Copy link
Contributor Author

bnb commented Nov 2, 2015

Aack - @Qard, can't edit on mobile.

@fhemberger
Copy link
Contributor

No, there isn't. I think for now it's fine to create a simple guides.md page with the three links in it.

@Qard
Copy link
Member

Qard commented Nov 3, 2015

Yeah, something static should be sufficient for now. We'll likely have to rewrite it entirely as we get docs structure worked out.

@lpinca lpinca mentioned this pull request Nov 6, 2015
@lpinca
Copy link
Member

lpinca commented Nov 17, 2015

Closing this as #334 has been merged.

@lpinca lpinca closed this Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants