Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added NiM link to documentation. Also 25 language additions to debugging documentation. #1938

Merged
merged 31 commits into from
Feb 20, 2019

Conversation

june07
Copy link
Contributor

@june07 june07 commented Dec 12, 2018

@nodejs/tsc #1923

…Bulgarian, Bengali, Czech, Danish, Greek, Estonian, Finnish, Hebrew, Hindi, Croatian, Hungarian, Indonesian, Georgian, Latvian, Dutch, Norwegian, Polish, Portuguese, Romanian, Russian, Slovak, Thai, Turkish, and Vietnamese
@june07 june07 changed the title Re-added NiM link to documentation. Re-added NiM link to documentation. Also 25 language additions to debugging documentation. Dec 14, 2018
@ghost
Copy link

ghost commented Dec 16, 2018

@nodejs/localization :This user has a great contributions of 25 languages. Can anyone of you related to the specific language to have a review of that?

@taggon
Copy link
Contributor

taggon commented Dec 17, 2018

The Korean translation looks good.

Copy link
Contributor

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ko directory.

locale/ko/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/ko/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should not be merged without input from @fhemberger, or unless there is a consensus that we should disregard the inicial concern.

There is also some active discussion going on in #1923 (comment) to research better options, and I believe that this should be blocked until that finishes.

@fhemberger
Copy link
Contributor

Labeled "on hold" until the discussion in #1923 is resolved. Please do not merge until then.

@june07
Copy link
Contributor Author

june07 commented Dec 28, 2018

@fhemberger The discussion in #1923 concluded 9 days ago. Issue was said to be more appropriately handled here. Any advice on getting this moved forward?

Copy link

@eiriksm eiriksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the Norwegian seemingly auto-translated content

locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/no/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
@june07
Copy link
Contributor Author

june07 commented Feb 8, 2019

Where are we at? Any more native speakers willing to contribute a +1 so we can get this pushed...?

@june07
Copy link
Contributor Author

june07 commented Feb 8, 2019

Now I'm thinking I should have maybe separated the language commits by branch or something. Lol.

@fhemberger
Copy link
Contributor

@june07 You could still split it up. Leave the translations that have been approved and remove the ones still waiting for review. Let's get this merged.

The page can still be translated later as well.

@june07
Copy link
Contributor Author

june07 commented Feb 13, 2019

@fhemberger Removed 22 locales which still need +1s and left 4 as follows:
Removed bg bn cs da el et fi he hi hr hu id ka lv pl pt ro sk sv th tr vi
Left ko nl ru ro

Should I create branches for each language instead of bunching them all into a single PR moving forward?

@ZYSzys
Copy link
Member

ZYSzys commented Feb 13, 2019

Should I create branches for each language instead of bunching them all into a single PR moving forward?

I'd prefer to create branches for each language since this makes code review easier than bunching them all into one.

@fhemberger
Copy link
Contributor

fhemberger commented Feb 14, 2019

Removed bg bn cs da el et fi he hi hr hu id ka lv pl pt ro sk sv th tr vi

I'm terribly sorry, I just noticed you provided a lot of translations for locales we don't even have (yet) on nodejs.org. There are discussions at the moment how to improve translations for the upcoming website redesign, but for now please stick to the locales we support right now:

ar, ca, de, en, es, fa, fr, gl, it, ja, ko, pt-br, uk, zh-cn and zh-tw

We only have members to review those. Also if a translation is not available, the website will fall back to the English version, so no worries.

@june07
Copy link
Contributor Author

june07 commented Feb 14, 2019

No worries. I guess that leaves ko all by itself.
Actually, nl, no, ru have gotten feedback in this PR. Am I removing these as well or leaving them?

I do understand what you are saying about having no members on the immediate team to review. However as I made decisions on choosing which languages to translate several months ago at the start of this, I did so by referencing node.js working groups https://nodejs.org/en/about/working-groups/#i18n. Might that be a potential source of help to validate?

I had started in on separating into branches/language per @ZYSzys. Should these PRs be submitted? I could assist with pinging someone from the applicable working groups if that helps to get them +1ed.

Let me know.

@fhemberger
Copy link
Contributor

Some of those groups date back to the io.js days (~4 years ago) and are not active any longer. So at the moment, only the languages you find in locales are supported on the site and have (more or less active) translation contributors.

…a, de, en, es, fa, fr, gl, it, ja, ko, pt-br, uk, zh-cn and zh-tw)
@june07
Copy link
Contributor Author

june07 commented Feb 14, 2019

Ok. Removed nl, no, ru as well.

@ChALkeR ChALkeR dismissed their stale review February 17, 2019 14:10

Outdated

@june07
Copy link
Contributor Author

june07 commented Feb 19, 2019

@fhemberger This should be good to go now.

@fhemberger fhemberger merged commit ceb9d13 into nodejs:master Feb 20, 2019
@fhemberger
Copy link
Contributor

@june07 Yes, it has been a long way. Thank you for your patience!

@june07
Copy link
Contributor Author

june07 commented Feb 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.