-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-added NiM link to documentation. Also 25 language additions to debugging documentation. #1938
Conversation
…Bulgarian, Bengali, Czech, Danish, Greek, Estonian, Finnish, Hebrew, Hindi, Croatian, Hungarian, Indonesian, Georgian, Latvian, Dutch, Norwegian, Polish, Portuguese, Romanian, Russian, Slovak, Thai, Turkish, and Vietnamese
@nodejs/localization :This user has a great contributions of 25 languages. Can anyone of you related to the specific language to have a review of that? |
The Korean translation looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed ko
directory.
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should not be merged without input from @fhemberger, or unless there is a consensus that we should disregard the inicial concern.
There is also some active discussion going on in #1923 (comment) to research better options, and I believe that this should be blocked until that finishes.
Labeled "on hold" until the discussion in #1923 is resolved. Please do not merge until then. |
@fhemberger The discussion in #1923 concluded 9 days ago. Issue was said to be more appropriately handled here. Any advice on getting this moved forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the Norwegian seemingly auto-translated content
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Co-Authored-By: june07 <[email protected]>
Where are we at? Any more native speakers willing to contribute a +1 so we can get this pushed...? |
Now I'm thinking I should have maybe separated the language commits by branch or something. Lol. |
@june07 You could still split it up. Leave the translations that have been approved and remove the ones still waiting for review. Let's get this merged. The page can still be translated later as well. |
@fhemberger Removed 22 locales which still need +1s and left 4 as follows: Should I create branches for each language instead of bunching them all into a single PR moving forward? |
I'd prefer to create branches for each language since this makes code review easier than bunching them all into one. |
I'm terribly sorry, I just noticed you provided a lot of translations for locales we don't even have (yet) on nodejs.org. There are discussions at the moment how to improve translations for the upcoming website redesign, but for now please stick to the locales we support right now: ar, ca, de, en, es, fa, fr, gl, it, ja, ko, pt-br, uk, zh-cn and zh-tw We only have members to review those. Also if a translation is not available, the website will fall back to the English version, so no worries. |
No worries. I guess that leaves ko all by itself. I do understand what you are saying about having no members on the immediate team to review. However as I made decisions on choosing which languages to translate several months ago at the start of this, I did so by referencing node.js working groups https://nodejs.org/en/about/working-groups/#i18n. Might that be a potential source of help to validate? I had started in on separating into branches/language per @ZYSzys. Should these PRs be submitted? I could assist with pinging someone from the applicable working groups if that helps to get them +1ed. Let me know. |
Some of those groups date back to the io.js days (~4 years ago) and are not active any longer. So at the moment, only the languages you find in |
…a, de, en, es, fa, fr, gl, it, ja, ko, pt-br, uk, zh-cn and zh-tw)
Ok. Removed nl, no, ru as well. |
@fhemberger This should be good to go now. |
@june07 Yes, it has been a long way. Thank you for your patience! |
Thanks and thank you.
…On Tue, Feb 19, 2019, 9:40 PM Frederic Hemberger ***@***.***> wrote:
@june07 <https://github.com/june07> Yes, it has been a long way. Thank
you for your patience!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK099rYgMwBEEugwsTe3tH9-1W4at52Mks5vPN_PgaJpZM4ZQDoU>
.
|
@nodejs/tsc #1923