Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Fix some Chinese translations #1686

Merged
merged 1 commit into from Jun 12, 2018
Merged

[Localization] Fix some Chinese translations #1686

merged 1 commit into from Jun 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2018

Change Logs:

  1. 其他 to 其它
  2. Remove useless spaces, and change English comma to Chinese one.
  3. Sign up for doesn't mean 注册. It means 报名登记参与……. According to the context, 注册订阅 is a right meaning.

@ghost ghost changed the title [Localization] Fix a wrong Chinese usage of 其他 [Localization] Fix some Chinese translations Jun 12, 2018
@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-cn

other-lts-downloads: 其他 LTS 下载
other-current-downloads: 其他最新版本下载
other-downloads: 其它下载
other-lts-downloads: 其它LTS版下载
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you have spaces between CJK and ASCII chararcters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed.
PS: Why? The formation recognization?

@@ -17,8 +17,8 @@ labels:
version-schedule-prompt: 可参考
version-schedule-prompt-link-text: LTS 日程。
newsletter: true
newsletter-prefix: 注册
newsletter-postfix: ", Node.js 官方的新闻周报。"
newsletter-prefix: 注册订阅
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you may just remove 注册.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Fixed

@laosb
Copy link

laosb commented Jun 12, 2018

Good job, thank you!

The original issue reported here:
#1685
@ghost
Copy link
Author

ghost commented Jun 12, 2018

You're welcome! All things have all been fixed.

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhemberger fhemberger merged commit 8b19366 into nodejs:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants