blog: fix indentation #1425

maclover7 · 2017-10-26T00:39:53Z

cjihrig

LGTM, but isn't all of this auto generated?

maclover7 · 2017-10-26T01:01:11Z

Welp, turns out the issue is that the changelog in nodejs/node for v8.8.1 is indented more than it should be... who knew two spaces could cause so much trouble... This should go in, but also looks the changelog will need to be fixed as well.

cjihrig · 2017-10-26T01:03:09Z

Ah, my bad. I'm going to land this.

maclover7 · 2017-10-26T01:04:13Z

no worries :) opened nodejs/node#16507 to fix this in nodejs/node

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

blog: fix indentation

938f7f6

cjihrig approved these changes Oct 26, 2017

View reviewed changes

cjihrig merged commit c056fa6 into nodejs:master Oct 26, 2017

maclover7 mentioned this pull request Oct 26, 2017

doc: fix indentation issue nodejs/node#16507

Closed

2 tasks

maclover7 deleted the jm-fix-indentation branch October 26, 2017 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

blog: fix indentation #1425

blog: fix indentation #1425

maclover7 commented Oct 26, 2017

cjihrig left a comment

maclover7 commented Oct 26, 2017

cjihrig commented Oct 26, 2017

maclover7 commented Oct 26, 2017

blog: fix indentation #1425

blog: fix indentation #1425

Conversation

maclover7 commented Oct 26, 2017

cjihrig left a comment

Choose a reason for hiding this comment

maclover7 commented Oct 26, 2017

cjihrig commented Oct 26, 2017

maclover7 commented Oct 26, 2017