Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Default Layout from nodejs.dev #5429

Closed
ovflowd opened this issue Jun 12, 2023 · 7 comments
Closed

Migrate the Default Layout from nodejs.dev #5429

ovflowd opened this issue Jun 12, 2023 · 7 comments
Labels
feature-request Requesting a new Technological Feature to be added to the Website good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign

Comments

@ovflowd
Copy link
Member

ovflowd commented Jun 12, 2023

Continuing the migration of components from nodejs.dev that we started here, the default layout including.

This issue will be used to track the migration of the Default layout. Also, note that I want this issue to be available for newcomers and not existing contributors if possible!

Migrating the Default layout

  • The layout should reside on layouts/NewDefault/index.tsx with styles on index.module.scss of the same folder.
  • The Layout should extend the DefaultLayout (like how we do with other legacy layouts, one layout extending another)
  • The Layout should extend the nodejs.dev DefaultLayout and support a (Header, Footer, Container with default paddings and children).
@ovflowd ovflowd added good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign feature-request Requesting a new Technological Feature to be added to the Website labels Jun 12, 2023
@ovflowd ovflowd moved this to 🔖 Ready in Website Redesign Jun 12, 2023
@ashutosh887
Copy link

@ovflowd
I Just saw that #5429 is a blocker for #5430
If you suggest, I'd like to work on this first and take up #5430 after this!

Please assign the issue to me

@ovflowd
Copy link
Member Author

ovflowd commented Jun 13, 2023

Sure, feel free to start working on this issue! Just a heads-up that we never assign issues to people on the issue itself, but feel free to work on it!

@ovflowd
Copy link
Member Author

ovflowd commented Jun 15, 2023

@ashutosh887 let me know if you're working on this :)

@ashutosh887
Copy link

Sure I'll go ahead with #5429 first
Any communication channel where I can discuss and update you on the progress?

@AugustinMauroy
Copy link
Member

We have a slack channel in OpenJs foundation slack.

OpenJS foundation slack #nodejs-website

@ashutosh887
Copy link

Thanks @AugustinMauroy
I've Joined it

@ovflowd
Copy link
Member Author

ovflowd commented Jul 27, 2023

Closing as this Layout will not be used anymore.

@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Website Redesign Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Requesting a new Technological Feature to be added to the Website good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign
Projects
Archived in project
Development

No branches or pull requests

3 participants