Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change assert.equal to assert.strictEqual #9946

Closed
wants to merge 3 commits into from
Closed

change assert.equal to assert.strictEqual #9946

wants to merge 3 commits into from

Conversation

aileenvl
Copy link

@aileenvl aileenvl commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

make a change from assert.equal() to asser.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

Please follow the commit message guidelines here.

@aileenvl aileenvl changed the title Change assert.equal to assert.strictEqual test: change assert.equal to assert.strictEqual Dec 1, 2016
@aileenvl aileenvl changed the title test: change assert.equal to assert.strictEqual test: change assert.equal to assert.strictEqual Change test from assert.equal() to assert.strictEqual() Dec 1, 2016
@aileenvl aileenvl changed the title test: change assert.equal to assert.strictEqual Change test from assert.equal() to assert.strictEqual() change assert.equal to assert.strictEqual Dec 1, 2016
Aileen added 2 commits December 1, 2016 11:09
test:change assert.equal() to assert.strictEqual()
d5be696 
this commit makes a change on test file from an asset.equal() to assert.strictEqual()
Merge branch 'typo-test-cluster-send-handle_Aileen' of https://github…
5d324db 
….com/aileenvl/node into typo-test-cluster-send-handle_Aileen

change commit message to follow guidelines
jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits will need to be squashed but LGTM

@addaleax
Copy link
Member

addaleax commented Dec 8, 2016

Landed in 558fa1c, thanks for the contribution!

@addaleax addaleax closed this Dec 8, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@addaleax
test: change assert.equal to assert.strictEqual
558fa1c 
PR-URL: #9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@addaleax
test: change assert.equal to assert.strictEqual
72fb05d 
PR-URL: #9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@addaleax
test: change assert.equal to assert.strictEqual
653f2b7 
PR-URL: nodejs#9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: change assert.equal to assert.strictEqual
bc125bd 
PR-URL: #9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: change assert.equal to assert.strictEqual
29dd2b8 
PR-URL: #9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: change assert.equal to assert.strictEqual
0b148b9 
PR-URL: #9946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aileenvl @mscdex @addaleax @jasnell @MylesBorins @imyller @nodejs-github-bot