Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: setTimeout must have at least 2 arguments + assert.strictEqual instead of equal #9933

Closed
wants to merge 0 commits into from

Conversation

junior
Copy link
Contributor

@junior junior commented Dec 1, 2016

Checklist

x make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
x commit message follows commit guidelines

Affected core subsystem(s)

test/parallel

Description of change

setTimeout with only 1 argument, should have 2 at least. Include 1 for the Delay.

and

assert.strictEqual() instead of assert.equal()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@junior May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@junior junior changed the title NInt2016-Adao test: setTimeout must have at least 2 arguments timer-arguments Dec 1, 2016
@junior
Copy link
Contributor Author

junior commented Dec 1, 2016

commit message changed to match the guidelines

@junior
Copy link
Contributor Author

junior commented Dec 1, 2016

comment template restored

@junior junior closed this Dec 1, 2016
@junior junior reopened this Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@junior PR info looks good but git commit message is still NInt2016-Adao

@junior
Copy link
Contributor Author

junior commented Dec 1, 2016

reverting wrong commit and sending a new PR, to make it right.

@junior junior closed this Dec 1, 2016
@junior junior reopened this Dec 1, 2016
@junior junior changed the title test: setTimeout must have at least 2 arguments timer-arguments test: setTimeout must have at least 2 arguments + assert.strictEqual instead of equal Dec 1, 2016
@Trott Trott closed this Dec 14, 2016
@Trott
Copy link
Member

Trott commented Dec 14, 2016

Argh, I did not intend to close this, but I pushed the wrong branch. And now I can't force-push to fix it because it's not my branch, I guess. Sorry about the error, @junior. I've opened #10269 with you as the author on the commit to get this change back in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants