Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run cpplint on files in test/cctest #9787

Merged
merged 0 commits into from
Dec 1, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Nov 24, 2016

Enable cpplint for files in test/cctest. Fix up the style issues it
reports.

cc @eugeneo, you should rebase #9630 after this.

CI: https://ci.nodejs.org/job/node-test-pull-request/4979/

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 24, 2016
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added test Issues and PRs related to the tests. inspector Issues and PRs related to the V8 inspector protocol labels Nov 24, 2016
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoordhuis bnoordhuis closed this Dec 1, 2016
@bnoordhuis bnoordhuis deleted the cpplint-cctest branch December 1, 2016 13:03
@bnoordhuis bnoordhuis merged commit 8264a22 into nodejs:master Dec 1, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Enable cpplint for files in test/cctest.  Fix up the style issues it
reports.

PR-URL: #9787
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Enable cpplint for files in test/cctest.  Fix up the style issues it
reports.

PR-URL: #9787
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Enable cpplint for files in test/cctest.  Fix up the style issues it
reports.

PR-URL: #9787
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Enable cpplint for files in test/cctest.  Fix up the style issues it
reports.

PR-URL: #9787
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Enable cpplint for files in test/cctest.  Fix up the style issues it
reports.

PR-URL: #9787
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants