Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change from setTimeout to setImmediate #9578

Closed
wants to merge 1 commit into from
Closed

test: change from setTimeout to setImmediate #9578

wants to merge 1 commit into from

Conversation

fossamagna
Copy link
Contributor

@fossamagna fossamagna commented Nov 12, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This is a part of Code And Learn at NodeFest 2016 Challenge
nodejs/code-and-learn#58

@fossamagna
test: change from setTimeout to setImmediate
316891f 
This is a part of Code And Learn at NodeFest 2016 Challenge
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2016
@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 12, 2016
@yosuke-furukawa
Copy link
Member

CI is green, LGTM

@shigeki
Copy link
Contributor

shigeki commented Nov 12, 2016

CI is running on https://ci.nodejs.org/job/node-test-pull-request/4830/.

shigeki
shigeki approved these changes Nov 12, 2016
View reviewed changes
Copy link
Contributor

@shigeki shigeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test failure is due to missing g++ path on CentOS7-64. Others are green. LGTM.

addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shigeki pushed a commit that referenced this pull request Nov 13, 2016
@fossamagna @shigeki
test: change from setTimeout to setImmediate
8a78fcb 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 8a78fcb.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 13, 2016
@shigeki shigeki mentioned this pull request Nov 18, 2016
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@fossamagna @addaleax
test: change from setTimeout to setImmediate
58fc7a1 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@fossamagna @addaleax
test: change from setTimeout to setImmediate
8a94c69 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: nodejs#9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@fossamagna @MylesBorins
test: change from setTimeout to setImmediate
b87fe25 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@fossamagna @MylesBorins
test: change from setTimeout to setImmediate
1bd8b28 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@fossamagna @MylesBorins
test: change from setTimeout to setImmediate
3329c2b 
This is a part of Code And Learn at NodeFest 2016 Challenge

Fixes: nodejs/code-and-learn#58
PR-URL: #9578
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fossamagna @yosuke-furukawa @shigeki @addaleax @cjihrig @mscdex @MylesBorins @nodejs-github-bot