Updated reference to signal list in "signal events" section #9323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the reference from sigaction(2) to signal(7) like requested in issue nodejs#9309
nodejs-github-bot
added
doc
cjihrig
requested changes
Oct 27, 2016
| @@ -374,7 +374,7 @@ The `*-deprecation` command line flags only affect warnings that use the name | |||
| <!--name=SIGINT, SIGHUP, etc.--> | |||
|
|
|||
| Signal events will be emitted when the Node.js process receives a signal. Please | |||
| refer to sigaction(2) for a listing of standard POSIX signal names such as | |||
| refer to [signal(7)](http://man7.org/linux/man-pages/man7/signal.7.html) for a listing of standard POSIX signal names such as | |||
There was a problem hiding this comment.
Can you move the URL to the bottom of the page with the others.
|
I don't think a link needs to be explicitly added since the doc tools automatically insert links when they see man page references. So just changing the 'sigaction(2)' to 'signal(7)' should be enough. |
I removed the link since the doc tool automatically add link to man pages.
|
LGTM |
|
@cjihrig I think you have to mark your requested changes as having been made (I'm not loving the new review system yet). LGTM |
cjihrig
approved these changes
Oct 27, 2016
sam-github
pushed a commit
that referenced
this pull request
Oct 27, 2016
Fixes: #9309 PR-URL: #9323 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Brian White <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
Fixes: #9309 PR-URL: #9323 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
Fixes: #9309 PR-URL: #9323 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
Fixes: #9309 PR-URL: #9323 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation is changed or added.
Changed the reference from sigaction(2) to signal(7) like requested in issue #9309