Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: fix TypeError in v8-polyfill #8863

Closed
wants to merge 1 commit into from
Closed

internal: fix TypeError in v8-polyfill #8863

wants to merge 1 commit into from

Conversation

geek
Copy link
Member

@geek geek commented Sep 30, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8 profile processor

Description of change

readline() can return a boolean, in which case, line 90 will throw an exception. This change addresses the issue by defaulting to a string in readline() instead of returning false.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 30, 2016
@mscdex mscdex added process Issues and PRs related to the process subsystem. and removed tools Issues and PRs related to the tools directory. labels Sep 30, 2016
jasnell
jasnell approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Sep 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4336/

bnoordhuis
bnoordhuis requested changes Oct 3, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the return false in readline() to return '', that way future call sites won't run into the same issue.

If other collaborators think this is fine though, I'm fine with it too.

@geek geek force-pushed the fix-v8-polyfill branch from b5a879b to d3f5d8a Compare October 4, 2016 21:30
@geek
Copy link
Member Author

geek commented Oct 4, 2016

@bnoordhuis fixed

@bnoordhuis
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4391/

@geek
Copy link
Member Author

geek commented Oct 5, 2016

This was the failure on AIX

https://ci.nodejs.org/job/node-test-commit-aix/1300/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1219 pseudo-tty/test-tty-wrap

I reran the job and it succeeded:

https://ci.nodejs.org/job/node-test-commit-aix/1305/

jasnell pushed a commit that referenced this pull request Oct 6, 2016
@geek @jasnell
lib: fix TypeError in v8-polyfill
47d1588 
PR-URL: #8863
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

Landed in 47d1588

@jasnell jasnell closed this Oct 6, 2016
@geek geek deleted the fix-v8-polyfill branch October 6, 2016 18:21
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@geek @jasnell
lib: fix TypeError in v8-polyfill
aa5664f 
PR-URL: #8863
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

added lts watch as this lands on v4.x let me know if it should not land

@jasnell
Copy link
Member

jasnell commented Oct 7, 2016

there's likely no harm in landing it.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@geek @Fishrock123
lib: fix TypeError in v8-polyfill
6cd5588 
PR-URL: #8863
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@geek
lib: fix TypeError in v8-polyfill
a3a184d 
PR-URL: #8863
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@geek @jasnell @bnoordhuis @MylesBorins @targos @cjihrig @mscdex @nodejs-github-bot