test: speed up test-net-reconnect-error #7886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: nodejs#7827 (comment)
Trott
added
net
|
@nodejs/testing |
|
This version of the test taking 20 seconds per run: https://ci.nodejs.org/job/node-stress-single-test/835/nodes=win2008r2/console Version on master taking 50 seconds per run: https://ci.nodejs.org/job/node-stress-single-test/832/nodes=win2008r2/console |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
CI failure looks infrastructure/build related and not anything to do with this change, but let's try again anyway: https://ci.nodejs.org/job/node-test-pull-request/3451/ |
|
CI is green. Landing... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 29, 2016
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: nodejs#7827 (comment) PR-URL: nodejs#7886 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 8fbdfb9 |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: #7827 (comment) PR-URL: #7886 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: #7827 (comment) PR-URL: #7886 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: #7827 (comment) PR-URL: #7886 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: #7827 (comment) PR-URL: #7886 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test net
Description of change
The test takes 50 seconds on some of the project's Windows CI
infrastructure. Reducing the test repetitions from 50 to 20 trims that
to about 20 seconds. Tests will timeout at 60 seconds, so this helps
keep the test reliable. (There was a timeout on CI today when testing an
unrelated code change.)
Refs: #7827 (comment)