doc: align breakEvalOnSigint - repl option #7849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
| @@ -392,7 +392,7 @@ added: v0.1.91 | |||
| equivalent to prefacing every repl statement with `'use strict'`. | |||
| * `repl.REPL_MODE_MAGIC` - attempt to evaluates expressions in default | |||
| mode. If expressions fail to parse, re-try in strict mode. | |||
| * `breakEvalOnSigint` - Stop evaluating the current piece of code when | |||
| * `breakEvalOnSigint` - Stop evaluating the current piece of code when | |||
| `SIGINT` is received, i.e. `Ctrl+C` is pressed. This cannot be used together | |||
| with a custom `eval` function. Defaults to `false`. | |||
There was a problem hiding this comment.
Could you re-align the two subsequent lines, too?
There was a problem hiding this comment.
There is no line break. View here
There was a problem hiding this comment.
Yeah, but they are still column-aligned in the raw markdown file.
|
LGTM with a comment |
|
LGTM, thanks! |
|
LGTM |
1 similar comment
|
LGTM |
|
Landed in c94887 |
princejwesley
added a commit
that referenced
this pull request
Jul 28, 2016
PR-URL: #7849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
PR-URL: #7849 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: JungMinu - Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
breakEvalOnSigintoption is wrongly aligned insidereplMode.