Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: deprecate unused function convertToContext #7829

Closed
wants to merge 5 commits into from
+32 −2
Closed

repl: deprecate unused function convertToContext #7829

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4ecbd8
repl: remove unused function convertToContext
princejwesley Jul 21, 2016
a096f00
Add deprecate warning for convertToContext
princejwesley Jul 27, 2016
326757e
Add todo and update deprecate text
princejwesley Jul 28, 2016
60f4a9f
Update deprecate message
princejwesley Jul 28, 2016
05ba902
Add test
princejwesley Jul 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,9 @@ function regexpEscape(s) {
* @param {String} cmd The cmd to convert.
* @return {String} The converted command.
*/
REPLServer.prototype.convertToContext = function(cmd) {
// TODO(princejwesley): Remove it prior to v8.0.0 release
// Reference: https://github.com/nodejs/node/pull/7829
REPLServer.prototype.convertToContext = util.deprecate(function(cmd) {
const scopeVar = /^\s*var\s*([_\w\$]+)(.*)$/m;
const scopeFunc = /^\s*function\s*([_\w\$]+)/;
var matches;
Expand All @@ -1222,7 +1224,7 @@ REPLServer.prototype.convertToContext = function(cmd) {
}

return cmd;
};
}, 'replServer.convertToContext will be removed after v7');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our deprecation messages typically take a form like, 'replServer.convertToContext() is deprecated', without committing to a specific version when it may be removed. The message should also indicate if there is an alternative that the developer should use.


function bailOnIllegalToken(parser) {
return parser._literal === null &&
Expand Down