-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: increase webkit scrollbar width and fix colors #6474
Conversation
/cc @nodejs/documentation, @nodejs/website, @claudiorodriguez, @mathiask88, @silverwind. |
This makes the navigation scrollbar background match with the navigation background, which should make it more obvious where that scrollbar belongs to (and that there is a scrollbar).
This increases webkit scrollbars width from 10px to 16px, but keeps the visual width at 10px until the scrollbar is hovered.
7bea67c
to
bcc3842
Compare
I would prefer default ones but I'm also happy with this, because now I am able to hit them without clicking around them :) |
Needs media queries to avoid eating extra space on small devices imo. |
TBH, I don't really like the light-on-dark on the left side, it just looks not as clean as before.
Doing media-queries for scrollbars seems just wrong to me. Can't we rely more on native browser behaviour to get these right? Imho, we should reduce scrollbar styling to the bare minimum so it looks visually pleasing. Ideally, that means only changing Don't forget to test on Windows too, Chrome has static scrollbars there (no floating ones like on OS X). |
+1 on moving back to native browser scrollbar. This thing has been broken several times now. |
Ok, so I made #6479 which, following suggestions from some, just removes all scrollbar styling altogether. |
Checklist
Affected core subsystem(s)
doc
Description of change
Only
-webkit-scrollbar-*
properties are affected.There are two changes here:
Unfortunately, the second change forced me to remove border-radius on unhovered scrollbars, but it still looks nice to me this way.
This is alternate to #6445 and should fix #6443.