Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: increase webkit scrollbar width and fix colors #6474

Closed
wants to merge 2 commits into from

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Apr 29, 2016

Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Only -webkit-scrollbar-* properties are affected.

There are two changes here:

  1. The background color of the left (navigation) scrollbar is fixed to match the background color of the navigation.
  2. The width of the scrollbars has been increased to 16px, but their visible width is 10px until the users hovers them. This way, they don't bother people who don't want to see gigantic scrollbars, but they are actually big enough for people who want to use them.

Unfortunately, the second change forced me to remove border-radius on unhovered scrollbars, but it still looks nice to me this way.

This is alternate to #6445 and should fix #6443.

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Apr 29, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 29, 2016

Screenshots:
screenshot_20160429_180425
screenshot_20160429_180451

/cc @nodejs/documentation, @nodejs/website, @claudiorodriguez, @mathiask88, @silverwind.

ChALkeR added 2 commits April 29, 2016 18:07
This makes the navigation scrollbar background match with the
navigation background, which should make it more obvious where that
scrollbar belongs to (and that there is a scrollbar).
This increases webkit scrollbars width from 10px to 16px, but keeps the
visual width at 10px until the scrollbar is hovered.
@ChALkeR ChALkeR force-pushed the docs-scrollbar-width branch from 7bea67c to bcc3842 Compare April 29, 2016 15:14
@ChALkeR ChALkeR changed the title doc: Increase scrollbar width and fix colors doc: increase webkit scrollbar width and fix colors Apr 29, 2016
@mathiask88
Copy link
Contributor

I would prefer default ones but I'm also happy with this, because now I am able to hit them without clicking around them :)

@Fishrock123
Copy link
Contributor

Needs media queries to avoid eating extra space on small devices imo.

@silverwind
Copy link
Contributor

silverwind commented Apr 29, 2016

TBH, I don't really like the light-on-dark on the left side, it just looks not as clean as before.

Needs media queries to avoid eating extra space on small devices imo.

Doing media-queries for scrollbars seems just wrong to me. Can't we rely more on native browser behaviour to get these right? Imho, we should reduce scrollbar styling to the bare minimum so it looks visually pleasing. Ideally, that means only changing background properties.

Don't forget to test on Windows too, Chrome has static scrollbars there (no floating ones like on OS X).

@eljefedelrodeodeljefe
Copy link
Contributor

+1 on moving back to native browser scrollbar. This thing has been broken several times now.

@claudiorodriguez
Copy link
Contributor

Ok, so I made #6479 which, following suggestions from some, just removes all scrollbar styling altogether.

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 29, 2016

Closing this in favor of #6479. Feel free to reopen if #6479 gets rejected or stalled.

@ChALkeR ChALkeR closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Scrollbar width
6 participants