test: remove the use of curl in the test suite

[santigimeno]

Pull Request check-list

Please make sure to review and check all of these items:

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)?
• Is the commit message formatted according to CONTRIBUTING.md?
• If this change fixes a bug (or a performance problem), is a regression
  test (or a benchmark) included?
• Is a documentation update included (if this change modifies
  existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

There were 2 tests using curl:

test-http-304.js is removed because it was initially included to test
that the 304 response does not contain a body, and this is already
covered by test-http-chunked-304.js.

test-http-curl-chunk-problem has been refactored so instead of using
curl, it uses 2 child node processes: one for sending the HTTP request
and the other to calculate the sha1sum. Originally, this test was
introduced to fix a bug in [email protected], and it was not fixed until
[email protected]. A modified version of this test has been run with
[email protected] and reproduces the problem. This same test has been run
with [email protected] and runs correctly.

[santigimeno]

It tries to fix #5174.
In case someone wants to test the new test with [email protected] and [email protected], I have setup a Dockerfile with wheezy (It installs initially [email protected]. [email protected] can be installed by running: apt-get install nodejs=0.2.6-5) and the test modified so it runs with [email protected] here: https://gist.github.com/santigimeno/4b534c2c2f77f3d90b29

[rvagg]

I'm a little hesitant to move forward with removing the explicit curl test from test-http-curl-chunk-problem but if what you say is correct that you can reproduce the problem with this new test case then (1) impressive work to go back so far and (2) I guess that's a positive sign that this is OK to move ahead, (although not definitive).

/cc @jbergstroem @nodejs/testing thoughts?

[bnoordhuis]

LGTM. I'm fine with renaming test-http-curl-chunk-problem.js; it's poorly named because the real issue wasn't with curl but with node.

[jbergstroem]

LGTM me too. If the curl test was specific to curl and not node it shouldn't have belong in our test suite anyway.

[Trott]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2034/

[Fishrock123]

Thanks, landed in 82fdaae!

---

/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:133: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

@santigimeno could you please set git config --global --add core.whitespace fix? Thanks! :D

[santigimeno]

@santigimeno could you please set git config --global --add core.whitespace fix? Thanks! :D

@Fishrock123 will do. Thanks