-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in child_process docs #5681
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
benjamingr
force-pushed
the
child-process-doc-typo-fix
branch
from
March 13, 2016 08:36
4ecf7c8
to
ec35ca0
Compare
thefourtheye
added
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
labels
Mar 13, 2016
From what I understand there is no need to wait 48 hours to land these changes - but I'd like to wait a few hours just to be sure no one has any surprising objections. |
Noticed that I created this on the main node repo by mistake - need to get used to the new UI options - apologies. |
LGTM |
benjamingr
added a commit
that referenced
this pull request
Mar 13, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
Closed by b217460 |
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fixes a typo in the child process docs. Fixes: nodejs/nodejs.org#573 PR-URL: #5681 Reviewed-By: thefourtheye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
@nodejs/documentation
Description of change
Please provide a description of the change here.
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573