Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor --trace-env to reuse option selection and handling #56293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joyeecheung
Copy link
Member

This reduces the duplication in the code base, also makes makes the log messages more concise since the [--trace-env] prefix should provide enough indication about the fact that it's about environment variable access.

This reduces the duplication in the code base, also makes
makes the log messages more concise since the `[--trace-env]`
prefix should provide enough indication about the fact that
it's about environment variable access.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 17, 2024
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@joyeecheung
Copy link
Member Author

cc @nodejs/cpp-reviewers

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (a50f3d5) to head (3c65551).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/node_env_var.cc 95.74% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56293      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.02%     
==========================================
  Files         657      657              
  Lines      190243   190288      +45     
  Branches    36536    36527       -9     
==========================================
+ Hits       168461   168476      +15     
- Misses      14963    14982      +19     
- Partials     6819     6830      +11     
Files with missing lines Coverage Δ
src/node_credentials.cc 68.72% <100.00%> (-0.56%) ⬇️
src/node_internals.h 81.03% <ø> (ø)
src/node_env_var.cc 86.80% <95.74%> (-0.30%) ⬇️

... and 43 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants