test: remove exludes for sea tests on PPC #56217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The referenced issue is closed as having been fixed, so the tests should run ok. Unexclude them. Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Dec 10, 2024
jasnell
approved these changes
Dec 10, 2024
richardlau
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56217 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 657 657
Lines 189858 189858
Branches 36450 36450
=======================================
+ Hits 168089 168095 +6
- Misses 14973 14976 +3
+ Partials 6796 6787 -9 |
lpinca
approved these changes
Dec 11, 2024
|
There is a typo in the commit message: exludes -> excludes. |
mhdawson
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e698bd0 |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
The referenced issue is closed as having been fixed, so the tests should run ok. Unexclude them. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #56217 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
The referenced issue is closed as having been fixed, so the tests should run ok. Unexclude them. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #56217 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced issue is closed as having been
fixed, so the tests should run ok. Unexclude them.