doc: fix incorrect link to style guide #56181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to the style guide in `pull-requests.md` linked to the main `README.md` instead of `doc/README.md`. This commit fixes the link. Refs: nodejs#41119
|
Review requested:
|
gireeshpunathil
approved these changes
Dec 8, 2024
RafaelGSS
approved these changes
Dec 8, 2024
lpinca
approved these changes
Dec 10, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 549037f |
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
The link to the style guide in `pull-requests.md` linked to the main `README.md` instead of `doc/README.md`. This commit fixes the link. Refs: #41119 PR-URL: #56181 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the style guide in the Code section of pull-requests.md was incorrectly pointing to the main
README.mdusing../../README.mdinstead ofdoc/README.md.Replaced
../../README.mdwith../../doc/README.md.Note that
../../doc/README.mdis equivalent to../README.mdin this context, but I think the former will be better for readability, emphasizing that thisREADME.mdis the one underdoc/.Refs: #41119