Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update gyp-next to 0.19.0 #56158

Merged
merged 1 commit into from
Dec 9, 2024
Merged

tools: update gyp-next to 0.19.0 #56158

merged 1 commit into from
Dec 9, 2024
+53 −36

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of gyp-next to 0.19.0.

@nodejs-github-bot nodejs-github-bot added gyp Issues and PRs related to the GYP tool and .gyp build files tools Issues and PRs related to the tools directory. labels Dec 6, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (4211ab5) to head (b6af813).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56158   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      189103   189103           
  Branches    35999    36001    +2     
=======================================
+ Hits       166421   166428    +7     
+ Misses      15860    15848   -12     
- Partials     6822     6827    +5

see 29 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63917/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63924/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63926/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit fdf225a into main Dec 9, 2024
88 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in fdf225a

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-gyp-next branch December 9, 2024 10:14
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@nodejs-github-bot @aduh95
tools: update gyp-next to 0.19.0
e20eef6 
PR-URL: #56158
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @lpinca @targos @gengjiawen @RafaelGSS @aduh95