Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x backport] module: add findPackageJSON util #56074

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[v22.x backport] module: add findPackageJSON util #56074

merged 2 commits into from
Dec 10, 2024

Conversation

JakobJingleheimer
Copy link
Member

PR-URL: #55412
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Antoine du Hamel [email protected]

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 29, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 29, 2024 •
edited
Loading

Can you also backport #55543 in the same PR please?

@JakobJingleheimer
Copy link
Member Author

JakobJingleheimer commented Nov 29, 2024 •
edited
Loading

Can you also backport #55543 in the same PR please?

Looks like the answer is yes 🙂

#55543 (comment)

@JakobJingleheimer
Copy link
Member Author

Can you also backport #55543 in the same PR please?

Well that was easy 😁

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63780/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63794/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63798/

@JakobJingleheimer
Copy link
Member Author

It looks like everything is green but coverage, which seems bogus: it passed on the original. To my knowledge, it already has full coverage (aside from #55822), so I'm not sure how to address this.

@JakobJingleheimer JakobJingleheimer mentioned this pull request Dec 7, 2024
Merged
@JakobJingleheimer JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 10, 2024
JakobJingleheimer and others added 2 commits December 10, 2024 22:15
@JakobJingleheimer @aduh95
module: add findPackageJSON util
807f34f 
PR-URL: nodejs#55412
Backport-PR-URL: nodejs#56074
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95
module: simplify findPackageJSON implementation
4f85047 
PR-URL: nodejs#55543
Backport-PR-URL: nodejs#56074
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#55412
@aduh95 aduh95 force-pushed the backport/add-findPackageJSON-util branch from 3a67999 to 4f85047 Compare December 10, 2024 21:21
@aduh95 aduh95 merged commit 4f85047 into nodejs:v22.x-staging Dec 10, 2024
18 of 20 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 10, 2024

Landed in 552a182...4f85047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

@ruyadorno ruyadorno Awaiting requested review from ruyadorno

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JakobJingleheimer @nodejs-github-bot @aduh95 @anonrig