-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921
Conversation
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
`util.getCallSite` returns an array of call site objects. Rename the function to reflect that it returns a given count of frames captured as an array of call site object. Renames the first parameter `frames` to be `frameCount` to indicate that it specifies the count of returned call sites. PR-URL: #55626 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55589 Fixes: #55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
GitHub Actions is by default running the tools updater workflow with Node.js 18. Avoid use of `import.meta.dirname`, which wasn't backported to Node.js 18. PR-URL: #55717 Refs: #55445 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55720 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #55551 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55728 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55711 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #55732 Refs: nodejs/Release#1054 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55734 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #55737 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #55738 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #55746 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The bufferSize option was not respected in recursive mode. This PR implements a naive solution to fix this issue until a better implementation can be designed. Fixes: #48820 PR-URL: #55744 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55710 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #55697 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55719 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #55772 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #55781 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: #55781 (comment) Refs: cli/cli#4142 PR-URL: #55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #55362 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
highlight additional points around triager role Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #55775 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55813 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55777 Fixes: #55518 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626 PR-URL: #55921
18eb60c
to
34dba0b
Compare
Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626 PR-URL: #55921
34dba0b
to
72f82ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v23.x #55921 +/- ##
==========================================
- Coverage 88.41% 88.01% -0.41%
==========================================
Files 654 653 -1
Lines 187665 187709 +44
Branches 36125 35884 -241
==========================================
- Hits 165930 165217 -713
- Misses 14965 15675 +710
- Partials 6770 6817 +47
|
### Notable Changes | ||
|
||
* \[[`5767b76c30`](https://github.com/nodejs/node/commit/5767b76c30)] - **doc**: enforce strict policy to semver-major releases (Rafael Gonzaga) [#55732](https://github.com/nodejs/node/pull/55732) | ||
* \[[`ccb69bb8d5`](https://github.com/nodejs/node/commit/ccb69bb8d5)] - **(SEMVER-MINOR)** **src**: add cli option to preserve env vars on dr (Rafael Gonzaga) [#55697](https://github.com/nodejs/node/pull/55697) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When working on the blog post, IMO it would be useful to amend this to say "diagnostic report" instead of "dr"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I also think that we should not accept "dr" in the commit message in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote it to not exceed the commit message length.
CITGM Results comparing against 3504 (v23.3.2-proposal)
@nodejs/undici, could you please check? https://ci.nodejs.org/job/citgm-smoker/3513/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/undici_v6_21_0/ |
Same failure on v20, you can ignore it #55879 (comment) |
Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626 PR-URL: #55921
* Blog: v23.3.0 release post Refs: nodejs/node#55921 * Update apps/site/pages/en/blog/release/v23.3.0.md Co-authored-by: Antoine du Hamel <[email protected]> Signed-off-by: Rafael Gonzaga <[email protected]> --------- Signed-off-by: Rafael Gonzaga <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>
Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) nodejs#55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) nodejs#55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) nodejs#55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) nodejs#55626 PR-URL: nodejs#55921
* Blog: v23.3.0 release post Refs: nodejs/node#55921 * Update apps/site/pages/en/blog/release/v23.3.0.md Co-authored-by: Antoine du Hamel <[email protected]> Signed-off-by: Rafael Gonzaga <[email protected]> --------- Signed-off-by: Rafael Gonzaga <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>
Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) nodejs#55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) nodejs#55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) nodejs#55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) nodejs#55626 PR-URL: nodejs#55921
2024-11-20, Version 23.3.0 (Current), @RafaelGSS
Notable Changes
5767b76c30
] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #55732ccb69bb8d5
] - (SEMVER-MINOR) src: add cli option to preserve env vars on dr (Rafael Gonzaga) #55697d4e792643d
] - (SEMVER-MINOR) util: add sourcemap support to getCallSites (Marco Ippolito) #5558900e092bb4b
] - (SEMVER-MINOR) util: fix util.getCallSites plurality (Chengzhong Wu) #55626Commits
9862912d41
] - assert: differentiate cases wherecause
isundefined
or missing (Antoine du Hamel) #5573832e5bbca95
] - benchmark: addtest-reporters
(Aviv Keller) #55757c2103354e6
] - benchmark: addtest_runner/mock-fn
(Aviv Keller) #55771472d55e3e4
] - build: implement node_use_amaro flag in GN build (Cheng) #5579877735674eb
] - build: use glob for dependencies of out/Makefile (Richard Lau) #55789bba7323d51
] - build: apply cpp linting and formatting to ncrypto (Aviv Keller) #55362e0c222525e
] - crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits (Filip Skokan) #55866cad557ec53
] - deps: update simdutf to 5.6.1 (Node.js GitHub Bot) #55850dc8aca3692
] - deps: update undici to 6.21.0 (Node.js GitHub Bot) #55851e0db9ede4f
] - deps: update c-ares to v1.34.3 (Node.js GitHub Bot) #55803e147935144
] - deps: update icu to 76.1 (Node.js GitHub Bot) #55551e0ef65b8d5
] - doc: remove non-working example (Antoine du Hamel) #55856ec953bca09
] - doc: addnode:sqlite
to mandatorynode:
prefix list (翠 / green) #558461b863b96d5
] - doc: add-S
flag release preparation example (Antoine du Hamel) #55836a8311847d1
] - doc: clarify UV_THREADPOOL_SIZE env var usage (Preveen P) #55832787e51e603
] - doc: add notable-change mention to sec release (Rafael Gonzaga) #55830e56265cc18
] - doc: fix history info forURL.prototype.toJSON
(Antoine du Hamel) #55818c5afdaf5cb
] - doc: correct max-semi-space-size statement (Joe Bowbeer) #5581265ffb2cae3
] - doc: update unflag info ofimport.meta.resolve
(skyclouds2001) #558109aeb671677
] - doc: run license-builder (github-actions[bot]) #55813df5ea1a5b3
] - doc: clarify triager role (Gireesh Punathil) #55775aa12de0f03
] - doc: sort --report-exclude alphabetically (Rafael Gonzaga) #557888576ca9897
] - doc: clarify removal of experimental API does not require a deprecation (Antoine du Hamel) #557465767b76c30
] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #557321f2fcf1dc8
] - doc: add history entries for JSON modules stabilization (Antoine du Hamel) #5585583ba688d8f
] - esm: fix import.meta.resolve crash (Marco Ippolito) #55777bdb6d12e7a
] - events: add hasEventListener util for validate (Sunghoon) #55230d41cb49516
] - fs: prevent unwanteddependencyOwners
removal (Carlos Espa) #55565db0d648d8f
] - fs: fix bufferSize option for opendir recursive (Ethan Arrowood) #55744693fda0802
] - lib: remove unused filefetch_module
(Michaël Zasso) #55880156873303a
] - lib: prefer symbol to number in webidltype
function (Antoine du Hamel) #55737cfe28b161a
] - lib: remove unnecessary optional chaining (Gürgün Dayıoğlu) #55728bbb8f5914d
] - lib: usePromise.withResolvers()
in timers (Yagiz Nizipli) #5572011e1bdd409
] - module: tidy code string concat → string templates (Jacob Smith) #558209c99255468
] - permission: ignore internalModuleStat on module loading (Rafael Gonzaga) #557975a437c446f
] - report: fix network queries in getReport libuv with exclude-network (Adrien Foulon) #55602bcbba723de
] - sqlite: add support for SQLite Session Extension (Bart Louwers) #5418149d55228de
] - src: use env strings to create sqlite results (Michaël Zasso) #5578558d7a6ec10
] - Revert "src: migrateString::Value
toString::ValueView
" (Michaël Zasso) #5582816786a6df8
] - src: improvenode:os
userInfo performance (Yagiz Nizipli) #55719ccb69bb8d5
] - (SEMVER-MINOR) src: add cli option to preserve env vars on dr (Rafael Gonzaga) #55697770670c52c
] - test: fix permission fixtures lint (Rafael Gonzaga) #5581984c47478d0
] - test: improve test coverage for child process message sending (Juan José) #55710e1f54e2527
] - test: ensure that test priority is not higher than current priority (Livia Medeiros) #55739e1b42e7637
] - test: add buffer to fs_permission tests (Rafael Gonzaga) #55734d1ad43e9ae
] - test: improve test coverage forServerResponse
(Juan José) #55711034505e037
] - test_runner: error on mocking an already mocked date (Aviv Keller) #5585844324aa7e9
] - tools: bump @eslint/plugin-kit from 0.2.0 to 0.2.3 in /tools/eslint (dependabot[bot]) #558753cfacd3fbb
] - tools: fix exclude labels for commit-queue (Richard Lau) #558098111a7655d
] - tools: make commit-queue check blocked label (Marco Ippolito) #55781419ea068fb
] - tools: remove non-existent file from eslint config (Aviv Keller) #557727814669377
] - tools: fix c-ares updater script for Node.js 18 (Richard Lau) #557173a9733cc4f
] - util: do not mark experimental feature as deprecated (Antoine du Hamel) #55740d4e792643d
] - (SEMVER-MINOR) util: add sourcemap support to getCallSites (Marco Ippolito) #5558900e092bb4b
] - (SEMVER-MINOR) util: fix util.getCallSites plurality (Chengzhong Wu) #55626