esm: fix import.meta.resolve crash

PR-URL: #55777 Fixes: #55518 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Nov 16, 2024 · 83ba688 · 83ba688
1 parent 9aeb671
commit 83ba688
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/node_modules.cc b/src/node_modules.cc
@@ -412,7 +412,10 @@ void BindingData::GetPackageScopeConfig(
     }
 
     auto file_url = url::FileURLToPath(realm->env(), *package_json_url);
-    CHECK(file_url);
+    if (!file_url) {
+      url::ThrowInvalidURL(realm->env(), resolved.ToStringView(), std::nullopt);
+      return;
+    }
     error_context.specifier = resolved.ToString();
     auto package_json = GetPackageJSON(realm, *file_url, &error_context);
     if (package_json != nullptr) {

diff --git a/test/es-module/test-esm-import-meta-resolve.mjs b/test/es-module/test-esm-import-meta-resolve.mjs
@@ -106,3 +106,15 @@ await assert.rejects(import('data:text/javascript,export default import.meta.res
     stdout: 'http://example.com/\n',
   });
 }
+
+{
+  const result = await spawnPromisified(execPath, [
+    '--no-warnings',
+    '--experimental-import-meta-resolve',
+    '--eval',
+    'import.meta.resolve("foo", "http://example.com/bar.js")',
+  ]);
+  assert.match(result.stderr, /ERR_INVALID_URL/);
+  assert.strictEqual(result.stdout, '');
+  assert.strictEqual(result.code, 1);
+}