Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix sign-compare warning in ncrypto #54624

Merged
merged 1 commit into from
Aug 31, 2024
Merged

deps: fix sign-compare warning in ncrypto #54624

merged 1 commit into from
Aug 31, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Aug 29, 2024

Fix following warning in GN build:

../../node/deps/ncrypto/ncrypto.cc:1197:12: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
 1197 |   if (size < dp.size()) {
      |       ~~~~ ^ ~~~~~~~~~

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 29, 2024
@anonrig anonrig requested a review from jasnell August 29, 2024 00:40
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61624/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 30, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/61682/ 💚

@zcbenz zcbenz added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Aug 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit d6f5234 into nodejs:main Aug 31, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d6f5234

@zcbenz zcbenz deleted the fix-ncrypto-warning branch August 31, 2024 02:11
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
@zcbenz @sendoru
deps: fix sign-compare warning in ncrypto
6540501 
PR-URL: nodejs#54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@zcbenz @aduh95
deps: fix sign-compare warning in ncrypto
6a32645 
PR-URL: #54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@zcbenz @louwers
deps: fix sign-compare warning in ncrypto
294f118 
PR-URL: nodejs#54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@zcbenz @tpoisseau
deps: fix sign-compare warning in ncrypto
df8e455 
PR-URL: nodejs#54624
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zcbenz @nodejs-github-bot @jasnell @anonrig @atlowChemi @targos