Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run V8 Fast API tests in release mode too #54570

Merged
merged 1 commit into from
Aug 30, 2024
Merged

test: run V8 Fast API tests in release mode too #54570

merged 1 commit into from
Aug 30, 2024

Conversation

targos
Copy link
Member

@targos targos commented Aug 26, 2024

Only keep the call count assertions under common.isDebug.

@targos
test: run V8 Fast API tests in release mode too
4d5dfea 
Only keep the call count assertions under `common.isDebug`.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 26, 2024
@targos
Copy link
Member Author

targos commented Aug 26, 2024

@anonrig you should like this :)

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (4f1c27a) to head (4d5dfea).
Report is 317 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54570      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +0.01%     
==========================================
  Files         649      649              
  Lines      182620   182620              
  Branches    35042    35046       +4     
==========================================
+ Hits       159490   159512      +22     
+ Misses      16394    16376      -18     
+ Partials     6736     6732       -4

see 34 files with indirect coverage changes

@anonrig
Copy link
Member

anonrig commented Aug 26, 2024

@anonrig you should like this :)

You know me! 🫡😂

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61512/

mcollina
mcollina approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61688/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61691/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8966787 into nodejs:main Aug 30, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8966787

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@targos @RafaelGSS
test: run V8 Fast API tests in release mode too
82edc71 
Only keep the call count assertions under `common.isDebug`.

PR-URL: #54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@targos @RafaelGSS
test: run V8 Fast API tests in release mode too
8b12255 
Only keep the call count assertions under `common.isDebug`.

PR-URL: #54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@targos @RafaelGSS
test: run V8 Fast API tests in release mode too
f85b88c 
Only keep the call count assertions under `common.isDebug`.

PR-URL: #54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Merged
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
@targos @sendoru
test: run V8 Fast API tests in release mode too
4a44188 
Only keep the call count assertions under `common.isDebug`.

PR-URL: nodejs#54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 1, 2024
@targos @RafaelGSS
test: run V8 Fast API tests in release mode too
522d5a3 
Only keep the call count assertions under `common.isDebug`.

PR-URL: #54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@targos @louwers
test: run V8 Fast API tests in release mode too
1af63b6 
Only keep the call count assertions under `common.isDebug`.

PR-URL: nodejs#54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@targos @tpoisseau
test: run V8 Fast API tests in release mode too
d4e1b8d 
Only keep the call count assertions under `common.isDebug`.

PR-URL: nodejs#54570
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@ronag ronag ronag approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @anonrig @mcollina @jasnell @benjamingr @ronag @RafaelGSS