buffer: truncate instead of throw when writing beyond buffer #54524

ronag · 2024-08-23T13:43:46Z

Fixes: nodejs#54523 PR-URL: nodejs#54524

OnlyAviv · 2024-08-23T13:53:03Z

@ronag I marked #54523 as a duplicate of #54521 and #54518, does this issue fix one of those too? (It looks like it might fix #54518, right?)

test/parallel/test-buffer-write.js

ronag · 2024-08-23T14:04:51Z

#54521 is not related to this

Fixes: nodejs#54523 PR-URL: nodejs#54524

github-actions · 2024-08-23T14:06:12Z

Fast-track has been requested by @ronag. Please 👍 to approve.

Fixes: nodejs#54523 PR-URL: nodejs#54524

Fixes: nodejs#54523 Fixes: nodejs#54518 PR-URL: nodejs#54524

OnlyAviv · 2024-08-23T14:18:26Z

#54521 is not related to this

But does it fix #54518?

ronag · 2024-08-23T14:28:28Z

#54521 is not related to this

But does it fix #54518?

I think so.

Ethan-Arrowood

I'm okay with this, but could it be considered a major, breaking change?

ronag · 2024-08-23T15:14:10Z

It's unbrraking.

codecov · 2024-08-23T15:43:24Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (628469c) to head (fcb2906).
Report is 340 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/buffer.js	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54524      +/-   ##
==========================================
- Coverage   87.34%   87.34%   -0.01%     
==========================================
  Files         649      649              
  Lines      182576   182626      +50     
  Branches    35036    35040       +4     
==========================================
+ Hits       159467   159507      +40     
- Misses      16381    16390       +9     
- Partials     6728     6729       +1

Files with missing lines	Coverage Δ
lib/internal/buffer.js	`97.41% <33.33%> (+0.26%)`	⬆️

... and 37 files with indirect coverage changes

jerome-benoit · 2024-08-23T15:58:59Z

It's unbrraking.

Of course it is: the semantic of dependent APIs is changed. But the initial upper bound check introduction should not have go without being flagged as a breaking change.

nodejs-github-bot · 2024-08-26T17:05:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61506/

nodejs-github-bot · 2024-08-27T03:57:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61523/

nodejs-github-bot · 2024-08-27T08:48:53Z

Landed in dd8eeec

nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]>

* chore(deps-dev): update development dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert to Node.js 22.6.0 nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Andrew Haines <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrew Haines <[email protected]>

This reverts commit dd8eeec. PR-URL: nodejs#54588 Refs: nodejs#54524

Wazbat · 2024-08-27T17:15:38Z

I'm unfamiliar with the node release process. Is there a rough estimate on when this will be released?

RafaelGSS · 2024-08-27T17:17:29Z

I'm unfamiliar with the node release process. Is there a rough estimate on when this will be released?

It should go out tomorrow. Follow #54560

Fixes: #54523 Fixes: #54518 PR-URL: #54524 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]>

* chore(deps-dev): update development dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix lint errors Signed-off-by: Andrew Haines <[email protected]> * Revert to Node.js 22.6.0 nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Andrew Haines <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrew Haines <[email protected]>

This reverts commit dd8eeec. PR-URL: #54588 Refs: #54524 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Fixes: nodejs#54523 Fixes: nodejs#54518 PR-URL: nodejs#54524 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This reverts commit dd8eeec. PR-URL: nodejs#54588 Refs: nodejs#54524 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Aug 23, 2024

ronag force-pushed the buffer-write-length-oob branch from e785336 to 9c112d9 Compare August 23, 2024 13:44

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2024

buffer: truncate instead of throw when writing beyond buffer

9c112d9

Fixes: nodejs#54523 PR-URL: nodejs#54524

OnlyAviv reviewed Aug 23, 2024

View reviewed changes

test/parallel/test-buffer-write.js Outdated Show resolved Hide resolved

ronag commented Aug 23, 2024

View reviewed changes

test/parallel/test-buffer-write.js Outdated Show resolved Hide resolved

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2024

buffer: truncate instead of throw when writing beyond buffer

ff17b6b

Fixes: nodejs#54523 PR-URL: nodejs#54524

ronag force-pushed the buffer-write-length-oob branch from 615fe78 to ff17b6b Compare August 23, 2024 14:05

ronag requested review from mcollina, benjamingr and targos August 23, 2024 14:05

ronag added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 23, 2024

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2024

buffer: truncate instead of throw when writing beyond buffer

e94a7f2

Fixes: nodejs#54523 PR-URL: nodejs#54524

ronag force-pushed the buffer-write-length-oob branch from ff17b6b to e94a7f2 Compare August 23, 2024 14:07

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2024

buffer: truncate instead of throw when writing beyond buffer

f6f2334

Fixes: nodejs#54523 PR-URL: nodejs#54524

ronag force-pushed the buffer-write-length-oob branch from e94a7f2 to f6f2334 Compare August 23, 2024 14:07

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2024

buffer: truncate instead of throw when writing beyond buffer

9b0a26a

Fixes: nodejs#54523 Fixes: nodejs#54518 PR-URL: nodejs#54524

ronag force-pushed the buffer-write-length-oob branch from f6f2334 to 9b0a26a Compare August 23, 2024 14:08

OnlyAviv mentioned this pull request Aug 23, 2024

ERR_BUFFER_OUT_OF_BOUNDS error with Google Vision package on Node 22.7.0 #54518

Closed

Ethan-Arrowood approved these changes Aug 23, 2024

View reviewed changes

benjamingr approved these changes Aug 23, 2024

View reviewed changes

BridgeAR approved these changes Aug 23, 2024

View reviewed changes

ronag requested a review from RafaelGSS August 26, 2024 09:24

omBratteng mentioned this pull request Aug 26, 2024

Update nodejs20 GoogleContainerTools/distroless#1647

Merged

RafaelGSS approved these changes Aug 26, 2024

View reviewed changes

OnlyAviv mentioned this pull request Aug 26, 2024

SWC + next.js + Node.js v22.7 #54532

Closed

ronag added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 27, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2024

nodejs-github-bot merged commit dd8eeec into nodejs:main Aug 27, 2024
52 checks passed

haines added a commit to cerbos/cerbos-sdk-javascript that referenced this pull request Aug 27, 2024

Revert to Node.js 22.6.0

209de9b

nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]>

ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024

buffer: Throw when writing beyond buffer"

6535f47

This reverts commit dd8eeec. PR-URL: nodejs#54588 Refs: nodejs#54524

ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024

buffer: Throw when writing beyond buffer"

2a80f7d

This reverts commit dd8eeec. PR-URL: nodejs#54588 Refs: nodejs#54524

ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024

buffer: throw when writing beyond buffer"

2edea24

This reverts commit dd8eeec. PR-URL: nodejs#54588 Refs: nodejs#54524

owmo-dev mentioned this pull request Aug 27, 2024

bug stuck script combomash/orchestrator#25

Closed

haines added a commit to cerbos/cerbos-sdk-javascript that referenced this pull request Sep 2, 2024

Revert to Node.js 22.6.0

f15712b

nodejs/node#54524 Signed-off-by: Andrew Haines <[email protected]>

wavedeck mentioned this pull request Sep 6, 2024

Server Reflection - Node.js v22.7.0 RangeError [ERR_BUFFER_OUT_OF_BOUNDS]: "length" is outside of buffer bounds grpc/grpc-node#2820

Closed

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024

jasnell pushed a commit that referenced this pull request Sep 28, 2024

buffer: throw when writing beyond buffer"

3800d60

This reverts commit dd8eeec. PR-URL: #54588 Refs: #54524 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

bugarela mentioned this pull request Nov 11, 2024

Error Running quint verify informalsystems/quint#1540

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buffer: truncate instead of throw when writing beyond buffer #54524

buffer: truncate instead of throw when writing beyond buffer #54524

ronag commented Aug 23, 2024

OnlyAviv commented Aug 23, 2024 •

edited

Loading

ronag commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

OnlyAviv commented Aug 23, 2024

ronag commented Aug 23, 2024

Ethan-Arrowood left a comment

ronag commented Aug 23, 2024

codecov bot commented Aug 23, 2024 •

edited

Loading

jerome-benoit commented Aug 23, 2024 •

edited

Loading

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 27, 2024

nodejs-github-bot commented Aug 27, 2024

Wazbat commented Aug 27, 2024

RafaelGSS commented Aug 27, 2024

buffer: truncate instead of throw when writing beyond buffer #54524

buffer: truncate instead of throw when writing beyond buffer #54524

Conversation

ronag commented Aug 23, 2024

OnlyAviv commented Aug 23, 2024 • edited Loading

ronag commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

OnlyAviv commented Aug 23, 2024

ronag commented Aug 23, 2024

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

ronag commented Aug 23, 2024

codecov bot commented Aug 23, 2024 • edited Loading

Codecov Report

jerome-benoit commented Aug 23, 2024 • edited Loading

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 27, 2024

nodejs-github-bot commented Aug 27, 2024

Wazbat commented Aug 27, 2024

RafaelGSS commented Aug 27, 2024

OnlyAviv commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading

jerome-benoit commented Aug 23, 2024 •

edited

Loading