Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use node:test in test-cli-syntax-bad #54513

Closed
wants to merge 3 commits into from
Closed

test: use node:test in test-cli-syntax-bad #54513

wants to merge 3 commits into from

Conversation

OnlyAviv
Copy link
Member

Now this test will output in the following format (via node:test). This can make debugging easier:

✔ Checking syntax for syntax/bad_syntax.js with -c (31.178327ms)
✔ Checking syntax for syntax/bad_syntax.js with --check (28.406593ms)
✔ Checking syntax for syntax/bad_syntax with -c (28.053855ms)
✔ Checking syntax for syntax/bad_syntax with --check (30.877816ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with -c (33.376369ms)
✔ Checking syntax for syntax/bad_syntax_shebang.js with --check (30.007192ms)
✔ Checking syntax for syntax/bad_syntax_shebang with -c (27.548402ms)
✔ Checking syntax for syntax/bad_syntax_shebang with --check (28.443502ms)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (e70bd47) to head (a33839d).
Report is 346 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54513      +/-   ##
==========================================
+ Coverage   87.34%   87.61%   +0.26%     
==========================================
  Files         649      650       +1     
  Lines      182524   182945     +421     
  Branches    35026    35395     +369     
==========================================
+ Hits       159420   160280     +860     
+ Misses      16373    15926     -447     
- Partials     6731     6739       +8

see 124 files with indirect coverage changes

@OnlyAviv OnlyAviv changed the title test: use node:test in test-cli-syntax.bad test: use node:test in test-cli-syntax-bad Aug 23, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Sep 5, 2024

It looks like there are CI failures.

@OnlyAviv OnlyAviv added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 5, 2024
@OnlyAviv
Copy link
Member Author

OnlyAviv commented Sep 7, 2024

It looks like there are CI failures.

Not anymore 😃

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 9, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62209/ 💛

jasnell pushed a commit that referenced this pull request Sep 10, 2024
@OnlyAviv @jasnell
test: use node:test in test-cli-syntax.bad
5de919b 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 10, 2024

Landed in 5de919b

@jasnell jasnell closed this Sep 10, 2024
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@OnlyAviv @aduh95
test: use node:test in test-cli-syntax.bad
722cd2e 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@OnlyAviv @aduh95
test: use node:test in test-cli-syntax.bad
3b1108b 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@OnlyAviv @aduh95
test: use node:test in test-cli-syntax.bad
b96ee30 
PR-URL: #54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@OnlyAviv @louwers
test: use node:test in test-cli-syntax.bad
0876e9e 
PR-URL: nodejs#54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@OnlyAviv @tpoisseau
test: use node:test in test-cli-syntax.bad
680f7c1 
PR-URL: nodejs#54513
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@OnlyAviv @cjihrig @nodejs-github-bot @jasnell @benjamingr @MoLow @targos