test_runner: finish build phase before running tests #54423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Aug 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54423 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 648 648
Lines 182321 182345 +24
Branches 34973 34974 +1
=======================================
+ Hits 159210 159234 +24
- Misses 16376 16379 +3
+ Partials 6735 6732 -3
|
github-actions
bot
removed
the
request-ci
This commit updates the test runner to wait for suites to finish building before starting any tests. This is necessary when test filtering is enabled, as suites may transition from filtered to not filtered depending on what is inside of them. Fixes: nodejs#54084 Fixes: nodejs#54154
cjihrig
force-pushed
the
filter-suite-order
branch
from
aff03a5 to
4cb8fba
Compare
|
Rebased after #54387 landed. I'm not quite sure why the GitHub UI was saying there was a conflict, but it didn't exist locally 🤷 |
github-actions
bot
removed
the
request-ci
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/54423 ✔ Done loading data for nodejs/node/pull/54423 ----------------------------------- PR info ------------------------------------ Title test_runner: finish build phase before running tests (#54423) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:filter-suite-order -> nodejs:main Labels author ready, test_runner Commits 1 - test_runner: finish build phase before running tests Committers 1 - cjihrig <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54423 Fixes: https://github.com/nodejs/node/issues/54084 Fixes: https://github.com/nodejs/node/issues/54154 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54423 Fixes: https://github.com/nodejs/node/issues/54084 Fixes: https://github.com/nodejs/node/issues/54154 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: finish build phase before running tests ℹ This PR was created on Sat, 17 Aug 2024 16:04:38 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54423#pullrequestreview-2244147856 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54423#pullrequestreview-2244290735 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-18T20:14:06Z: https://ci.nodejs.org/job/node-test-pull-request/61207/ - Querying data for job/node-test-pull-request/61207/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10456894484 |
nodejs-github-bot
added
the
commit-queue-failed
|
This needs a re-approval after the rebase to appease the commit queue. |
MoLow
approved these changes
Aug 20, 2024
jakecastelli
approved these changes
Aug 20, 2024
jakecastelli
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ef4bdbf |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
This commit updates the test runner to wait for suites to finish building before starting any tests. This is necessary when test filtering is enabled, as suites may transition from filtered to not filtered depending on what is inside of them. Fixes: #54084 Fixes: #54154 PR-URL: #54423 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
3 tasks
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore the first commit. That is #54387, which is currently blocked from landing because the macOS machine in the CI has a full disk.
This commit updates the test runner to wait for suites to finish
building before starting any tests. This is necessary when test
filtering is enabled, as suites may transition from filtered to
not filtered depending on what is inside of them.
Fixes: #54084
Fixes: #54154