-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix emit warning for debuglog.time when disabled #54275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Aug 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54275 +/- ##
==========================================
- Coverage 87.10% 87.10% -0.01%
==========================================
Files 647 648 +1
Lines 181754 182214 +460
Branches 34880 34969 +89
==========================================
+ Hits 158323 158715 +392
- Misses 16742 16786 +44
- Partials 6689 6713 +24
|
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
approved these changes
Aug 11, 2024
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: James M Snell <[email protected]>
H4ad
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Aug 13, 2024
joyeecheung
approved these changes
Aug 15, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 15, 2024
RafaelGSS
approved these changes
Aug 21, 2024
Merged
RafaelGSS
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 27, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 27, 2024
Landed in a7271ab |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54275 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54275 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 22, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54275 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54265
The code of debuglog.time was executing because the internal flag
timerFlags
had the value7
and the comparison was wrong, instead of checking if the enum flags were activated (2 | 4
), I was just making a===
comparison.Now this behavior is fixed by just doing the comparison correctly, I also added a test to track this regression.
In theory, this bug slowed down a little bit all the
requires
but not too much since the heavy part was skipped.