Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: faster type check #54088

Merged
merged 1 commit into from
Aug 3, 2024
Merged

buffer: faster type check #54088

merged 1 commit into from
Aug 3, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 28, 2024 •
edited
Loading

Also add support for any TypedArray as target.

buffers/buffer-copy.js n=6000000 partial='true' bytes=128          ***     50.28 %       ±4.26% ±5.68%  ±7.42%
buffers/buffer-copy.js n=6000000 partial='true' bytes=8            ***     45.58 %       ±4.53% ±6.04%  ±7.89%

@ronag
Copy link
Member Author

ronag commented Jul 28, 2024

@nodejs/performance @nodejs/buffer

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jul 28, 2024
@ronag ronag requested a review from mcollina July 28, 2024 22:24
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
mcollina
mcollina approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60696/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60700/

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffers: faster type check
1235ae8 
Also add support for any TypedArray as target.

PR-URL: nodejs#54088
@ronag ronag force-pushed the buffer.copy-check branch from 0db82cb to 1235ae8 Compare July 29, 2024 08:45
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffers: faster type check
e993fc6 
Also add support for any TypedArray as target.

PR-URL: nodejs#54088
@ronag ronag force-pushed the buffer.copy-check branch from 1235ae8 to e993fc6 Compare July 29, 2024 08:46
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffers: faster type check
21a5831 
Also add support for any TypedArray as target.

PR-URL: nodejs#54088
@ronag ronag force-pushed the buffer.copy-check branch from e993fc6 to 21a5831 Compare July 29, 2024 08:46
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60711/

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffer: faster type check
4f088e6 
Also add support for any TypedArray as target.

PR-URL: nodejs#54088
@ronag ronag force-pushed the buffer.copy-check branch from 21a5831 to 4f088e6 Compare July 29, 2024 09:16
@ronag ronag changed the title buffers: faster type check buffer: faster type check Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (76c8ba9) to head (2d75eba).
Report is 519 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54088   +/-   ##
=======================================
  Coverage   87.06%   87.07%           
=======================================
  Files         643      643           
  Lines      181581   181582    +1     
  Branches    34888    34886    -2     
=======================================
+ Hits       158097   158107   +10     
+ Misses      16766    16758    -8     
+ Partials     6718     6717    -1
Files with missing lines Coverage Δ
lib/buffer.js 96.42% <100.00%> (+<0.01%) ⬆️

... and 25 files with indirect coverage changes

@tniessen
Copy link
Member

The commit message has to be amended to comply with our guidelines (prefix: imperative verb) before this can land :)

@tniessen
Copy link
Member

Is this semver-minor since it changes the public API? In any case, I think it makes sense to document the change in behavior. I assume the right place is to add a changes: block here:

node/doc/api/buffer.md

Lines 1711 to 1715 in 269175b

### `buf.copy(target[, targetStart[, sourceStart[, sourceEnd]]])`
<!-- YAML
added: v0.1.90
-->

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60779/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60820/

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 2, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54088
✔  Done loading data for nodejs/node/pull/54088
----------------------------------- PR info ------------------------------------
Title      buffer: faster type check (#54088)
Author     Robert Nagy <[email protected]> (@ronag)
Branch     ronag:buffer.copy-check -> nodejs:main
Labels     buffer, author ready, needs-ci
Commits    1
 - buffer: faster type check
Committers 1
 - Robert Nagy <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 28 Jul 2024 22:18:55 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2210972720
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2204005543
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2205608335
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2206203933
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-08-02T05:56:32Z: https://ci.nodejs.org/job/node-test-pull-request/60820/
- Querying data for job/node-test-pull-request/60820/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10213732908

@ronag
buffer: faster type check
2d75eba 
Also add support for any TypedArray as target.

PR-URL: nodejs#54088
@ronag ronag requested a review from anonrig August 2, 2024 11:13
@ronag ronag force-pushed the buffer.copy-check branch from 324f2c6 to 2d75eba Compare August 2, 2024 11:14
@ronag ronag requested review from mcollina and jasnell August 3, 2024 11:33
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60842/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60845/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60846/

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2024
@nodejs-github-bot nodejs-github-bot merged commit acbd0be into nodejs:main Aug 3, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in acbd0be

targos pushed a commit that referenced this pull request Aug 14, 2024
@ronag @targos
buffer: faster type check
ab6fae9 
Also add support for any TypedArray as target.

PR-URL: #54088
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

@mcollina mcollina Awaiting requested review from mcollina

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ronag @nodejs-github-bot @tniessen @mcollina @jasnell @benjamingr @anonrig @targos