Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: start using ncrypto for CSPRNG calls #53984

Merged
merged 1 commit into from
Jul 23, 2024
Merged

src: start using ncrypto for CSPRNG calls #53984

merged 1 commit into from
Jul 23, 2024

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 21, 2024

No description provided.

@jasnell jasnell requested review from anonrig and tniessen July 21, 2024 21:09
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@jasnell jasnell force-pushed the start-using-ncrypto branch from 4df80ae to 6fd9b19 Compare July 21, 2024 21:12
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jul 21, 2024
anonrig
anonrig approved these changes Jul 21, 2024
View reviewed changes
src/node.cc Show resolved Hide resolved
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen requested a review from bnoordhuis July 22, 2024 11:32
@tniessen
Copy link
Member

FWIW, this partially undoes @bnoordhuis's attempt at making this more difficult to misuse (see https://github.com/nodejs-private/node-private/pull/346#discussion_r967795383 if you have access).

@jasnell
Copy link
Member Author

jasnell commented Jul 22, 2024

FWIW, this partially undoes @bnoordhuis's attempt at making this more difficult to misuse

I never really agreed that that made any real difference one way or the other but if folks feel strongly about it I can retain that.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/60536/ 💛

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit c112b4b into nodejs:main Jul 23, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c112b4b

targos pushed a commit that referenced this pull request Jul 28, 2024
@jasnell @targos
src: start using ncrypto for CSPRNG calls
476965d 
PR-URL: #53984
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@jasnell @RafaelGSS
src: start using ncrypto for CSPRNG calls
bd4a9ff 
PR-URL: #53984
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @tniessen @anonrig @Ethan-Arrowood @targos