Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: reword linter messages #53949

Merged
merged 1 commit into from
Jul 21, 2024
Merged

meta: reword linter messages #53949

merged 1 commit into from
Jul 21, 2024

Conversation

OnlyAviv
Copy link
Member

This PR rewords the eslint messages to uniformly include only formal language (I.E. No 'We').

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 19, 2024
aduh95
aduh95 reviewed Jul 19, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Jul 19, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
@OnlyAviv OnlyAviv requested a review from aduh95 July 19, 2024 16:12
aduh95
aduh95 reviewed Jul 19, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
@OnlyAviv
Copy link
Member Author

I made the suggestions, added . periods, and fixed the message for module, as it is importable.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 19, 2024
@aduh95 aduh95 merged commit e8c2acf into nodejs:main Jul 21, 2024
21 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jul 21, 2024

Landed in e8c2acf

targos pushed a commit that referenced this pull request Jul 28, 2024
@OnlyAviv @targos
meta: reword linter messages
cb5a602 
PR-URL: #53949
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@OnlyAviv @RafaelGSS
meta: reword linter messages
b312ec0 
PR-URL: #53949
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OnlyAviv @aduh95 @jasnell @targos @nodejs-github-bot