Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor webstorage implementation #53876

Merged
merged 1 commit into from
Jul 18, 2024
Merged

src: refactor webstorage implementation #53876

merged 1 commit into from
Jul 18, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 16, 2024 •
edited
Loading

I couldn't find a good way to split them into multiple pull-requests.

@anonrig anonrig requested a review from cjihrig July 16, 2024 20:37
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 16, 2024
@anonrig anonrig force-pushed the refactor-webstorage branch from 8af37ce to bb81c4e Compare July 16, 2024 20:49
cjihrig
cjihrig approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the tests will pass with these changes, but LGTM if they do pass.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60369/

@cjihrig
Copy link
Contributor

cjihrig commented Jul 16, 2024

As I suspected, the tests appear to be failing. The inputs to these APIs do not need to be strings, but must be able to be converted to strings.

@anonrig
Copy link
Member Author

anonrig commented Jul 16, 2024

As I suspected, the tests appear to be failing. The inputs to these APIs do not need to be strings, but must be able to be converted to strings.

TIL. So, apparently null and undefined values are converted into string with the current approach. Reverting those changes now. Thanks for the review @cjihrig

@anonrig anonrig force-pushed the refactor-webstorage branch from bb81c4e to e53f1ad Compare July 16, 2024 23:11
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60373/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60377/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60393/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60394/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit 05b7bf0 into nodejs:main Jul 18, 2024
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 05b7bf0

targos pushed a commit that referenced this pull request Jul 28, 2024
@anonrig @targos
src: refactor webstorage implementation
55461be 
PR-URL: #53876
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @cjihrig @jasnell @targos