lib: refactor platform utility methods
#53817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
|
Are these two separate commits (unrelated to one another), or should they be squashed during merge?
|
|
b66edfa should be a separate PR IMO, can you remove it or revert it in this PR please? |
They’re very much related; I separated them just because one is focussed basically on DRYing up the
@RedYetiDev @aduh95 Done, and moved to #53820. |
danielbayley
force-pushed
the
utility-platform-cleanup
branch
from
b66edfa to
cd83c5b
Compare
github-actions
bot
removed
the
request-ci
daeyeon
approved these changes
Jul 12, 2024
OnlyAviv
reviewed
Jul 13, 2024
jasnell
approved these changes
Jul 13, 2024
danielbayley
force-pushed
the
utility-platform-cleanup
branch
from
cd83c5b to
1d413e8
Compare
marco-ippolito
approved these changes
Jul 14, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jul 15, 2024
Qard
approved these changes
Jul 15, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 953abf4 |
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53817 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53817 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Merged
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53817 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salvaging some of the cleanup work previously done in #53547, for fewer LOC, reuse of methods, and better consistency.