test: fix test-timers.reliability on OS X #5379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
timers
|
LGTM, thank you @Trott! |
|
LGTM |
|
Looks like Windows and ARM fanned hosts are not up and running in CI yet. Will try again later... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 25, 2016
Fixes: nodejs#4404 PR-URL: nodejs#5379 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
CI is 💚 Landed in 8bcb174 |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Fixes: #4404 PR-URL: #5379 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Fixes: #4404 PR-URL: #5379 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Fixes: #4404 PR-URL: #5379 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fixes: #4404 PR-URL: #5379 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
make test-timersso that it works on OS X. (Still won't work everywhere else except some Linux variants.)/cc @misterdjules @Fishrock123
Fixes: #4404