Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support lint-js-fix in vcbuild.bat #53695

Merged
merged 1 commit into from
Aug 6, 2024
Merged

build: support lint-js-fix in vcbuild.bat #53695

merged 1 commit into from
Aug 6, 2024

Conversation

OnlyAviv
Copy link
Member

@OnlyAviv OnlyAviv commented Jul 2, 2024

#53046 had merge conflicts that would not disappear, this PR is a re-write of that one to prevent further conflicts.

Previously approved by: @jasnell @anonrig @MoLow @H4ad

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Jul 2, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60020/

@OnlyAviv
Copy link
Member Author

OnlyAviv commented Jul 9, 2024 •
edited
Loading

Hey, is this ready for commit-queue? Thanks!

(Assuming no more merge conflicts)

@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 9, 2024
@H4ad
Copy link
Member

H4ad commented Jul 9, 2024

Not yet, we need to wait the security releases to be able to retry the CI that is failing.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60459/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60515/

@OnlyAviv
Copy link
Member Author

All tests pass :-)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60562/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit accf2ac into nodejs:main Aug 6, 2024
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in accf2ac

targos pushed a commit that referenced this pull request Aug 14, 2024
@OnlyAviv @targos
build: support lint-js-fix in vcbuild.bat
350e699 
PR-URL: #53695
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@H4ad H4ad H4ad approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@OnlyAviv @nodejs-github-bot @H4ad @jasnell @anonrig @StefanStojanovic @VoltrexKeyva @targos @aduh95