src: do not get string_view from temp string #53688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of std::string().substr() will be destroyed at the end of expression and creating std::string_view from it results in dangling pointer.
nodejs-github-bot
added
c++
anonrig
approved these changes
Jul 2, 2024
joyeecheung
approved these changes
Jul 2, 2024
anonrig
added
the
author ready
zcbenz
added
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jul 4, 2024
github-actions
bot
removed
the
request-ci
zcbenz
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2fd798d |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
The result of std::string().substr() will be destroyed at the end of expression and creating std::string_view from it results in dangling pointer. PR-URL: #53688 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
The result of std::string().substr() will be destroyed at the end of expression and creating std::string_view from it results in dangling pointer. PR-URL: #53688 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
std::string().substr()will be destroyed at the end of expression and creatingstd::string_viewfrom it results in dangling pointer.