Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: update js2c.py to js2c.cc #53543

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

codediverdev
Copy link
Contributor

Small update in a realm.js documentation comment to update js2c.py to js2c.cc. js2c.py was ported to js2c.cc and removed.

Small update in a realm.js documentation comment to correct js2c.py 
which was ported to js2c.cc and removed.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 22, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 22, 2024
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 22, 2024
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 merged commit cba170d into nodejs:main Jun 22, 2024
33 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jun 22, 2024

Landed in cba170d

@codediverdev codediverdev deleted the update-js2c-comment branch June 24, 2024 17:22
targos pushed a commit that referenced this pull request Jun 25, 2024
Small update in a realm.js documentation comment to correct `js2c.py`
which was ported to `js2c.cc` and removed.

PR-URL: #53543
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
targos pushed a commit that referenced this pull request Jun 25, 2024
Small update in a realm.js documentation comment to correct `js2c.py`
which was ported to `js2c.cc` and removed.

PR-URL: #53543
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Small update in a realm.js documentation comment to correct `js2c.py`
which was ported to `js2c.cc` and removed.

PR-URL: #53543
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Small update in a realm.js documentation comment to correct `js2c.py`
which was ported to `js2c.cc` and removed.

PR-URL: #53543
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants