-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: update js2c.py to js2c.cc #53543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small update in a realm.js documentation comment to correct js2c.py which was ported to js2c.cc and removed.
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Jun 22, 2024
joyeecheung
approved these changes
Jun 22, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Jun 22, 2024
aduh95
approved these changes
Jun 22, 2024
ShogunPanda
approved these changes
Jun 22, 2024
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Ethan-Arrowood
approved these changes
Jun 22, 2024
Landed in cba170d |
targos
pushed a commit
that referenced
this pull request
Jun 25, 2024
Small update in a realm.js documentation comment to correct `js2c.py` which was ported to `js2c.cc` and removed. PR-URL: #53543 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 25, 2024
Small update in a realm.js documentation comment to correct `js2c.py` which was ported to `js2c.cc` and removed. PR-URL: #53543 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Small update in a realm.js documentation comment to correct `js2c.py` which was ported to `js2c.cc` and removed. PR-URL: #53543 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Small update in a realm.js documentation comment to correct `js2c.py` which was ported to `js2c.cc` and removed. PR-URL: #53543 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
lib / src
Issues and PRs related to general changes in the lib or src directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update in a realm.js documentation comment to update
js2c.py
tojs2c.cc
.js2c.py
was ported to js2c.cc and removed.