-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-dgram-udp4 #5339
Conversation
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code.
f7f15c7
to
631a6dc
Compare
LGTM |
I'm not sure removing the timeout is a great call, otherwise the test will get stuck instead of failing (as far as I understand it). |
@mcollina the idea was that the test runner timeout handled it. Sometimes the use of timeouts has been a source of test flakiness. Do you see it as a problem? |
No, I'm happy with this. |
LGTM |
Agreed. See: nodejs/testing#19 |
are you a contributor here, or should I land this? |
I am not, please land. Thanks |
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#5339
Landed in dff01d1 |
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #5339
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #5339
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #5339
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #5339
This test was sometimes timing out in
OS X
. Remove the timeout andclean up the code.
This test has failed in my
OS X
box with this error: