doc: mark --cpu-prof and --heap-prof as stable #53343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cli
|
I believe the process requires pinging the TSC when changing the stability index, so cc @nodejs/tsc |
richardlau
approved these changes
Jun 5, 2024
ShogunPanda
approved these changes
Jun 5, 2024
ruyadorno
approved these changes
Jun 5, 2024
marco-ippolito
approved these changes
Jun 5, 2024
legendecas
approved these changes
Jun 6, 2024
joyeecheung
added
the
author ready
lpinca
approved these changes
Jun 6, 2024
trivikr
approved these changes
Jun 7, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53343 ✔ Done loading data for nodejs/node/pull/53343 ----------------------------------- PR info ------------------------------------ Title doc: mark --cpu-prof and --heap-prof as stable (#53343) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:prof-stable -> nodejs:main Labels doc, cli, author ready Commits 2 - doc: mark --cpu-prof and related flags stable - doc: mark --heap-prof and related flags stable Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/53343 Reviewed-By: Matteo Collina Reviewed-By: Richard Lau Reviewed-By: Paolo Insogna Reviewed-By: Ruy Adorno Reviewed-By: Marco Ippolito Reviewed-By: Chengzhong Wu Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53343 Reviewed-By: Matteo Collina Reviewed-By: Richard Lau Reviewed-By: Paolo Insogna Reviewed-By: Ruy Adorno Reviewed-By: Marco Ippolito Reviewed-By: Chengzhong Wu Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 05 Jun 2024 10:21:32 GMT ✔ Approvals: 9 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098775174 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098794896 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098801130 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2099519437 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2099556656 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2101341580 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103112398 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103234911 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103692231 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 479b8e5232..a2233c39c8 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - ab971dc739 src: use v8::(Des|S)erializeInternalFieldsCallback - a2233c39c8 src: use v8::(Des|S)erializeInternalFieldsCallback -------------------------------------------------------------------------------- HEAD is now at a2233c39c8 src: use v8::(Des|S)erializeInternalFieldsCallback ✔ Reset to origin/main - Downloading patch for 53343 From https://github.com/nodejs/node * branch refs/pull/53343/merge -> FETCH_HEAD ✔ Fetched commits as a2233c39c830..4dda1e792a8a -------------------------------------------------------------------------------- Auto-merging doc/api/cli.md [main d088d84b6d] doc: mark --cpu-prof and related flags stable Author: Joyee Cheung Date: Wed Jun 5 12:16:00 2024 +0200 1 file changed, 24 insertions(+), 4 deletions(-) Auto-merging doc/api/cli.md [main 80e66b769c] doc: mark --heap-prof and related flags stable Author: Joyee Cheung Date: Wed Jun 5 12:17:10 2024 +0200 1 file changed, 24 insertions(+), 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9416349123 |
gireeshpunathil
approved these changes
Jun 7, 2024
RafaelGSS
approved these changes
Jun 7, 2024
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
|
Landed in 1945072...673511f |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos
added a commit
that referenced
this pull request
Jun 25, 2024
Notable changes: deps,lib,src: * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435 doc: * move `node --run` stability to rc (Yagiz Nizipli) #53433 * mark WebSocket as stable (Matthew Aitken) #53352 * mark --heap-prof and related flags stable (Joyee Cheung) #53343 * mark --cpu-prof and related flags stable (Joyee Cheung) #53343 * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329 inspector: * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473 lib: * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340 util: * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107 PR-URL: #53583
targos
added a commit
that referenced
this pull request
Jun 26, 2024
Notable changes: deps,lib,src: * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435 doc: * move `node --run` stability to rc (Yagiz Nizipli) #53433 * mark WebSocket as stable (Matthew Aitken) #53352 * mark --heap-prof and related flags stable (Joyee Cheung) #53343 * mark --cpu-prof and related flags stable (Joyee Cheung) #53343 * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329 inspector: * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473 lib: * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340 util: * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107 PR-URL: #53583
targos
added a commit
that referenced
this pull request
Jul 1, 2024
Notable changes: deps,lib,src: * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435 doc: * move `node --run` stability to rc (Yagiz Nizipli) #53433 * mark WebSocket as stable (Matthew Aitken) #53352 * mark --heap-prof and related flags stable (Joyee Cheung) #53343 * mark --cpu-prof and related flags stable (Joyee Cheung) #53343 * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329 inspector: * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473 lib: * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340 util: * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107 PR-URL: #53583
targos
added a commit
that referenced
this pull request
Jul 2, 2024
Notable changes: deps,lib,src: * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435 doc: * move `node --run` stability to rc (Yagiz Nizipli) #53433 * mark WebSocket as stable (Matthew Aitken) #53352 * mark --heap-prof and related flags stable (Joyee Cheung) #53343 * mark --cpu-prof and related flags stable (Joyee Cheung) #53343 * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329 inspector: * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473 lib: * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340 util: * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107 PR-URL: #53583
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I remember the reason for keeping them experimental was to leave some room to allow (potentially breaking) customization of directories and profile name patterns. But at this point it seems the
--diagnostic-diroption that controls the default directory works well enough for the first case, and profile name patterns are part of a bigger issue of name patterns for many other outputs (reports, traces, etc.) and I expect any breaking changes will need to be semver-major together with other stable features that would share the same customization. So there is not really any point to keep them experimental (also, I believe they have been used enough in the wild that it may be unwise to break them without going semver-major at this point). So this PR just marks them as stable since that's already the reality.