test_runner: calculate executed lines using source map #53315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Amazing work! Thanks a lot for this! |
benjamingr
approved these changes
Jun 3, 2024
cjihrig
reviewed
Jun 3, 2024
cjihrig
approved these changes
Jun 4, 2024
MoLow
added
request-ci
github-actions
bot
removed
the
request-ci
MoLow
added
the
commit-queue
atlowChemi
approved these changes
Jun 4, 2024
MoLow
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 419172f |
6 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 7, 2024
PR-URL: #53315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
6 tasks
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53315 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52775 (comment)
Supersedes #53153
before this fix, the lines that were actually executed were calculated using the source file on the disk - this is not the case when using ES loaders/transpilers.
since we don't need the actual code run we create fake lines with a dummy char, just to map the dummy line to its original source