-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc, meta: organize contributing to Node-API guide #53243
Conversation
Review requested:
|
Co-authored-by: Gabriel Schulhof <[email protected]>
Co-authored-by: Gabriel Schulhof <[email protected]>
Co-authored-by: Gabriel Schulhof <[email protected]>
Co-authored-by: Chengzhong Wu <[email protected]>
Co-authored-by: Chengzhong Wu <[email protected]>
Co-authored-by: Chengzhong Wu <[email protected]>
Commit Queue failed- Loading data for nodejs/node/pull/53243 ✔ Done loading data for nodejs/node/pull/53243 ----------------------------------- PR info ------------------------------------ Title doc, meta: organize contributing to Node-API guide (#53243) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:patch-40 -> nodejs:main Labels doc, meta, node-api Commits 9 - doc, meta: organize contributing to Node-API guide - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md - Update adding-new-napi-api.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/53243 Reviewed-By: Gabriel Schulhof Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53243 Reviewed-By: Gabriel Schulhof Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 01 Jun 2024 17:45:31 GMT ✔ Approvals: 2 ✔ - Gabriel Schulhof (@gabrielschulhof): https://github.com/nodejs/node/pull/53243#pullrequestreview-2106066624 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53243#pullrequestreview-2133496697 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53243 From https://github.com/nodejs/node * branch refs/pull/53243/merge -> FETCH_HEAD ✔ Fetched commits as cba170d8833d..05b5c1ef3e7a -------------------------------------------------------------------------------- [main 06143e6b08] doc, meta: organize contributing to Node-API guide Author: Aviv Keller <[email protected]> Date: Sat Jun 1 13:42:54 2024 -0400 1 file changed, 55 insertions(+), 61 deletions(-) [main 3f31b28da0] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Sat Jun 8 07:57:08 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main 673df66be9] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Sat Jun 8 07:57:13 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main 1489b9f042] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Sat Jun 8 07:57:19 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main 3b697135c3] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Mon Jun 17 11:23:21 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main 2b33087040] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Mon Jun 17 11:25:22 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main aa1d7d744c] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Mon Jun 17 11:25:32 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) [main b1f2288665] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Mon Jun 17 11:52:52 2024 -0500 1 file changed, 2 insertions(+), 1 deletion(-) [main 32d67ae73a] Update adding-new-napi-api.md Author: Aviv Keller <[email protected]> Date: Tue Jun 18 08:27:03 2024 -0500 1 file changed, 9 deletions(-) ✔ Patches applied There are 9 commits in the PR. Attempting autorebase. Rebasing (2/18)https://github.com/nodejs/node/actions/runs/9626875573 |
Landed in 69abdcd |
PR-URL: #53243 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #53243 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #53243 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #53243 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
This pull request restructures the Node-API guide by segmenting it into sections. The current guide, with its lengthy list, might appear intimidating and strict to contributors. However, by categorizing the list into subsections, contributors can more easily pinpoint the necessary steps for a successful contribution.